- Notifications
You must be signed in to change notification settings - Fork163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Get series with realtime#11
Open
elmotec wants to merge3 commits intomortada:masterChoose a base branch fromelmotec:get_series_with_realtime
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
please rebase |
ef78d83
to45a1ac2
CompareRebased. |
Removed usage of sys.stderr in mock exception which caused the stream tobe closed. This in turn failed the next test. Simplified test_search toavoid the zip and the loop.
3fe6082
toaa1db9b
CompareArguments realtime_start and realtime_end in get_series() now cause apandas.DataFrame to be returned with pandas.MultiIndex for realtimedata. Added simple test for the new feature and documentation.Added __init__.py in fredapi.tests so it's correctly interpreted asa package. Now we could revert to python setup.py test in .travis.yml.Fixed test_invalid_kwarg_in_get_series() as we sometimes get aTypeError and sometimes a ValueError. Seems that pandas passes throughwhatever exception it gets, might be a good reason for this so wefollow the same policy.Simplified comparison of dataframe output in tests.
aa1db9b
to095b9f6
Compare9999-12-31 cannot be converted to pandas.Timestamp because it's too big.Reason it's prefereable to use pandas.Timestamp than datetime.datetimeis that the former can be used as an index whereas the second cannot.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey@mortada, this is a PR to address the issue I mentioned in#9. That's only the part that handle realtime_start and realtime_end as first class citizens in get_series().
I should have get_dataframe() (to query multiple series in one call at specific times) ready sometimes in October.