This part of the code makes a copy of the original reference without calling the destructor at any time for it (original reference).
Instead of using a default constructor / copy constructor and then one destructor for each, such C++ copy elision optimization, it's better to simply remove copy.

Simple example of the problem:

publicglobal::Lldb.SBSymbolContextGetSymbolContext(uintresolve_scope){var__ret=newglobal::Lldb.SBSymbolContext.__Internal();__Internal.GetSymbolContext((__Instance+__PointerAdjustment),newIntPtr(&__ret),resolve_scope);// here __ret is initialized like a constructorreturnglobal::Lldb.SBSymbolContext.__CreateInstance(__ret);}internalstaticglobal::Lldb.SBSymbolContext__CreateInstance(global::Lldb.SBSymbolContext.__Internalnative,boolskipVTables=false){returnnewglobal::Lldb.SBSymbolContext(native,skipVTables);}privateSBSymbolContext(global::Lldb.SBSymbolContext.__Internal native,bool skipVTables= false):this(__CopyValue(native),skipVTables){__ownsNativeInstance=true;NativeToManagedMap[__Instance]=this;}privatestaticvoid*__CopyValue(global::Lldb.SBSymbolContext.__Internalnative){varret=Marshal.AllocHGlobal(sizeof(global::Lldb.SBSymbolContext.__Internal));global::Lldb.SBSymbolContext.__Internal.cctor(ret,newglobal::System.IntPtr(&native));returnret.ToPointer();}

After the fix:

privatestaticvoid*__CopyValue(global::Lldb.SBSymbolContext.__Internalnative){varret=Marshal.AllocHGlobal(sizeof(global::Lldb.SBSymbolContext.__Internal));*(global::Lldb.SBSymbolContext.__Internal*)ret=native;returnret.ToPointer();}

Fixing a memory leak

81a4dcd

This part of the code makes a copy of the original reference without calling the destructor at any time for it (original reference).Instead of using a default constructor / copy constructor and then one destructor for each, such C++ copy elision optimization, it's better to simply remove copy.Simple example of the problem:public global::Lldb.SBSymbolContext GetSymbolContext(uint resolve_scope){  var __ret = new global::Lldb.SBSymbolContext.__Internal();  __Internal.GetSymbolContext((__Instance + __PointerAdjustment), new IntPtr(&__ret), resolve_scope); // here __ret is initialized like a constructor  return global::Lldb.SBSymbolContext.__CreateInstance(__ret);}internal static global::Lldb.SBSymbolContext __CreateInstance(global::Lldb.SBSymbolContext.__Internal native, bool skipVTables = false){  return new global::Lldb.SBSymbolContext(native, skipVTables);}private SBSymbolContext(global::Lldb.SBSymbolContext.__Internal native, bool skipVTables = false)  : this(__CopyValue(native), skipVTables){  __ownsNativeInstance = true;  NativeToManagedMap[__Instance] = this;}private static void* __CopyValue(global::Lldb.SBSymbolContext.__Internal native){  var ret = Marshal.AllocHGlobal(sizeof(global::Lldb.SBSymbolContext.__Internal));  global::Lldb.SBSymbolContext.__Internal.cctor(ret, new global::System.IntPtr(&native));  return ret.ToPointer();}After the fix:private static void* __CopyValue(global::Lldb.SBSymbolContext.__Internal native){  var ret = Marshal.AllocHGlobal(sizeof(global::Lldb.SBSymbolContext.__Internal));  *(global::Lldb.SBSymbolContext.__Internal*) ret = native;  return ret.ToPointer();}

Copy link

dnfclas commentedMay 23, 2018•
edited
Loading

Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign ourContributor License Agreement before we can accept your contribution.

❌ Jaders77sign now
_{You have signed the CLA already but the status is still pending? Let usrecheck it.}