Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore: fix release action#94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
durran merged 2 commits intomainfromno-story-fix-release-action
Sep 15, 2025
Merged

Conversation

@baileympearson
Copy link
Contributor

Description

Summary of Changes

This PR fixes the release action.

Some past context: This package depends on the npm package whatwg-url. Version 13.x of of whatwg-url supports Node 16, but prints deprecation warnings when used. Version 14.x does not support Node16 but does not used deprecated code. We support both, and let npm choose which to install based on the user's Node version. But this means that we can't have a package-lock file if we want our CI to install the correct version of whatwg-url in our CI, so we've removed the package-lock from this repo. Once we are Node20+, we can add the package-lock.json back and update whatwg-url to 15.x, resolving this issue permanently. This PR is a workaround so we can release one last version of mongodb-connection-string-url for devtools before the next major version.

Notes for Reviewers

What is the motivation for this change?

Release Highlight

Release notes highlight

Double check the following

  • Lint is passing (npm run check:lint)
  • Self-review completed using thesteps outlined here
  • PR title follows thecorrect format:type(NODE-xxxx)[!]: description
    • Example:feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@baileympearsonbaileympearson requested a review froma team as acode ownerSeptember 15, 2025 10:55
@durrandurran merged commitd5dd934 intomainSep 15, 2025
30 checks passed
@durrandurran deleted the no-story-fix-release-action branchSeptember 15, 2025 13:54
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@durrandurrandurran approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@baileympearson@durran

[8]ページ先頭

©2009-2025 Movatter.jp