- Notifications
You must be signed in to change notification settings - Fork13
chore: fix release action#94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
durran approved these changesSep 15, 2025
d5dd934 intomain 30 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Summary of Changes
This PR fixes the release action.
Some past context: This package depends on the npm package whatwg-url. Version 13.x of of whatwg-url supports Node 16, but prints deprecation warnings when used. Version 14.x does not support Node16 but does not used deprecated code. We support both, and let npm choose which to install based on the user's Node version. But this means that we can't have a package-lock file if we want our CI to install the correct version of whatwg-url in our CI, so we've removed the package-lock from this repo. Once we are Node20+, we can add the package-lock.json back and update whatwg-url to 15.x, resolving this issue permanently. This PR is a workaround so we can release one last version of mongodb-connection-string-url for devtools before the next major version.
Notes for Reviewers
What is the motivation for this change?
Release Highlight
Release notes highlight
Double check the following
npm run check:lint)type(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript