- Notifications
You must be signed in to change notification settings - Fork13
chore: update exports entry in package.json with type mappings#89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
addaleax approved these changesSep 4, 2025
kmruiz approved these changesSep 4, 2025
baileympearson approved these changesSep 4, 2025
a40bacf intomain 30 checks passed
Uh oh!
There was an error while loading.Please reload this page.
himanshusinghs added a commit that referenced this pull requestSep 4, 2025
This was referencedSep 4, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Description
This PR proposes adding explicit type mappings in the exports entry of the package.json so that library consumers don't have to manually map types in their tsconfig, an examplehere.
What is changing?
We're adding an entry for types in the exports entry in package.json
Is there new documentation needed for these changes?
No
What is the motivation for this change?
We'd like to avoid doing explicit type mappings likesthis.
Release Highlight
Fill in title or leave empty for no highlight
Double check the following
npm run lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript