- Notifications
You must be signed in to change notification settings - Fork13
chore(NODE-7041): update dependencies and use standard Node team eslint configuration#86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 22.17.0 to 24.1.0.- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node)---updated-dependencies:- dependency-name: "@types/node" dependency-version: 24.1.0 dependency-type: direct:development update-type: version-update:semver-major...Signed-off-by: dependabot[bot] <support@github.com>
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
nbbeeken approved these changesAug 12, 2025
Collaborator
nbbeeken left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
fwiw lgtm!
durran approved these changesAug 13, 2025
d324bac intomain 30 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Description
What is changing?
Updates all stale dev dependencies to latest. Additionally, as discussed in slack, I adjusted the eslint configuration to use our standard eslint tooling (adapted from @mongodb-js/zstd, a simpler config than the driver's). This also required reformatting.
Finally, adopting
@typescript-eslint/eslint-pluginbreaks lint on Node16 because@typescript-eslint/eslint-pluginuses structuredClone. I fixed this by moving lint to a separate Github action that runs on Node22 instead of linting each test variant (other repos of ours only run lint on latest).Is there new documentation needed for these changes?
What is the motivation for this change?
Release Highlight
Fill in title or leave empty for no highlight
Double check the following
npm run lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript