- Notifications
You must be signed in to change notification settings - Fork13
chore(NODE-5389): add release automation#34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
aditi-khare-mongoDB left a comment• edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM, just a few copy paste problems
.github/scripts/release_notes.mjs Outdated
| const releaseNotes = `${header} | ||
| The MongoDB Node.js team is pleased to announce version ${version.version} of the \`mongodb\` package! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
| TheMongoDBNode.jsteamispleasedtoannounceversion${version.version}ofthe \`mongodb\`package! | |
| TheMongoDBNode.jsteamispleasedtoannounceversion${version.version}ofthe \`mongodb-connection-string-url\`package! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
fixed
.github/scripts/release_notes.mjs Outdated
| * [API](https://mongodb.github.io/node-mongodb-native/${version.major}.${version.minor}/) | ||
| * [Changelog](https://github.com/mongodb/node-mongodb-native/blob/v${version.version}/HISTORY.md) | ||
| We invite you to try the \`mongodb\` library immediately, and report any issues to the [NODE project](https://jira.mongodb.org/projects/NODE). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
| Weinviteyoutotrythe \`mongodb\`libraryimmediately,andreportanyissuestothe[NODEproject](https://jira.mongodb.org/projects/NODE). | |
| Weinviteyoutotrythe \`mongodb-connection-string-url\`libraryimmediately,andreportanyissuestothe[NODEproject](https://jira.mongodb.org/projects/NODE). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
fixed
Description
What is changing?
Is there new documentation needed for these changes?
No
What is the motivation for this change?
Release automation uniformity
Double check the following
npm run lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript