Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: update exports entry with type mappings for ESM consumers#91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
baileympearson merged 2 commits intomainfromfix/add-type-mappings
Sep 4, 2025

Conversation

@himanshusinghs
Copy link
Contributor

@himanshusinghshimanshusinghs commentedSep 4, 2025
edited by baileympearson
Loading

Note: This PR is a copy of#89 which we reverted because it was incorrectly marked aschore. With this PR, we are proposing the same changes with correct categorisation (fix) for semantic release.

Description

This PR proposes adding explicit type mappings in the exports entry of the package.json so that library consumers don't have to manually map types in their tsconfig, an examplehere.

What is changing?

We're adding an entry for types in the exports entry in package.json

Is there new documentation needed for these changes?

No

What is the motivation for this change?

We'd like to avoid doing explicit type mappings likesthis.

Release Highlight

package.json now specifies the correct types for ESM users

Before this release, the type exports from the package.json did not properly export a typing file for ESM bundles. This required users to explicitly import the correct types in their Typescript or bundler configurations.

Now, the package.json correctly specifies a types file for the ESM bundle of this library.

Double check the following

  • Rannpm run lint script
  • Self-review completed using thesteps outlined here
  • PR title follows thecorrect format:type(NODE-xxxx)[!]: description
    • Example:feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@himanshusinghshimanshusinghs requested a review froma team as acode ownerSeptember 4, 2025 21:45
@baileympearsonbaileympearson merged commit8d93166 intomainSep 4, 2025
30 checks passed
@baileympearsonbaileympearson deleted the fix/add-type-mappings branchSeptember 4, 2025 21:54
@github-actionsgithub-actionsbot mentioned this pull requestSep 4, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@baileympearsonbaileympearsonbaileympearson approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@himanshusinghs@baileympearson

[8]ページ先頭

©2009-2025 Movatter.jp