- Notifications
You must be signed in to change notification settings - Fork14
chore: writes compiled mongosh to lib-boxednode instead of lib to avoid linking it twice when building node#43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
…id linking it twice when building node
Looking into test failures. Even though the the file was linked during building, the final binary is not able to require it for some reason. Works fine, if I write to source tree root and include it from there. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Maybehttps://github.com/nodejs/node/blob/main/BUILDING.md#building-nodejs-with-external-core-modules is helpful here? i.e. the lines below
mainSource=mainSource.replace(/\bREPLACE_WITH_ENTRY_POINT\b/g,JSON.stringify(`${namespace}/${namespace}`));
may need to become
mainSource=mainSource.replace(/\bREPLACE_WITH_ENTRY_POINT\b/g,JSON.stringify(`/lib-boxednode/${namespace}/${namespace}`));
(and we could also drop the double namespacing here now I think, previously that was only there to avoid potential conflicts with existing files inlib/)
That was actually it, thank you for pointing, I missed that. |
…based on node.js version
Uh oh!
There was an error while loading.Please reload this page.
As pointed by Anna, probably because of changes (1,2) in between Node16 to Node20, the compiled mongosh file that we used to write under
libdir in node source tree was getting linked twice when building Node, but one the mentioned changes made this an error state and our compilation started failing after switching to Node20.With this change we will start writing the compiled mongosh file to
lib-boxednodedir in node source tree instead ofliband will continue linking it (only once) with--link-modulearg.