Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

ADC DMA mode for STM32 F1, F2, F37, F4, F7 and L1#982

Merged

Conversation

victorandrehc
Copy link
Contributor

@victorandrehcvictorandrehc commentedMar 17, 2023•
edited
Loading

This Pull request enable a more advanced use of the ADC by adding support to DMA and externally triggered ADC.

Tasks to publish:

  • Double check the f37 family checks, to guarantee that no functionality is left out.
  • Add an example for stm32f401re combining ADC, DMA and an external trigger.
  • Add methods to separately enable and disable the adc (for external clock management)

@victorandrehc
Copy link
ContributorAuthor

@chris-durand this is the branch with the adc support. I still want to add a small example of that, but I will be able to do that when I have free time, hence in draft mode.

@victorandrehcvictorandrehcforce-pushed thefeature/adc_dma_mode branch 2 times, most recently from1372cd3 to9989317CompareMarch 17, 2023 22:38
@victorandrehcvictorandrehcforce-pushed thefeature/adc_dma_mode branch 3 times, most recently from6f8c9c5 to6dda424CompareMarch 22, 2023 12:30
@chris-durand
Copy link
Member

Hi@victorandrehc, I didn't find time yet to review your PR, sorry. I'll have a look tomorrow.

@victorandrehcvictorandrehcforce-pushed thefeature/adc_dma_mode branch 4 times, most recently from4b31b0b to8cb5e4fCompareMarch 24, 2023 23:02
@victorandrehcvictorandrehc marked this pull request as ready for reviewMarch 25, 2023 07:17
@victorandrehc
Copy link
ContributorAuthor

@chris-durand I finally had the time to work directly on this PR, but now all tasks should also be completed

@victorandrehcvictorandrehcforce-pushed thefeature/adc_dma_mode branch 2 times, most recently from9342974 toc45c6bfCompareMarch 28, 2023 06:42
Copy link
Member

@chris-durandchris-durand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks!

@victorandrehc
Copy link
ContributorAuthor

@chris-durand, I saw your review, will work on the changes tomorrow.

chris-durand reacted with thumbs up emoji

@victorandrehcvictorandrehcforce-pushed thefeature/adc_dma_mode branch 5 times, most recently fromfca078b to30343c8CompareMarch 29, 2023 07:35
@victorandrehc
Copy link
ContributorAuthor

@chris-durand all reviews are done.

chris-durand reacted with thumbs up emoji

@chris-durand
Copy link
Member

@chris-durand all reviews are done.

Thanks!

@victorandrehc
Copy link
ContributorAuthor

@chris-durand last review suggestion was committed already. Can you please set the tag to run the complete test?

@chris-durandchris-durand added the ci:halTriggers the exhaustive HAL compile CI jobs labelMar 31, 2023
@chris-durand
Copy link
Member

@chris-durand last review suggestion was committed already. Can you please set the tag to run the complete test?

Done, I am planning to merge tonight.

victorandrehc reacted with thumbs up emoji

@chris-durandchris-durand changed the titleFeature/adc dma modeADC DMA mode for STM32 F1, F2, F37, F4, F7 and L1Mar 31, 2023
@chris-durandchris-durand merged commit04ed0a5 intomodm-io:developApr 1, 2023
@salkiniumsalkinium added this to the2023q1 milestoneApr 8, 2023
@victorandrehcvictorandrehc deleted the feature/adc_dma_mode branchFebruary 19, 2024 08:50
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@chris-durandchris-durandchris-durand approved these changes

Assignees
No one assigned
Labels
advanced 🤯ci:halTriggers the exhaustive HAL compile CI jobsfeature 🚧
Milestone
2023q1
Development

Successfully merging this pull request may close these issues.

3 participants
@victorandrehc@chris-durand@salkinium
[8]ページ先頭
©2009-2025 Movatter.jp