- Notifications
You must be signed in to change notification settings - Fork149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
[fiber] Add stack overflow check in every yield#1219
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
57170b1 tod4908daCompare0a2cd26 tof2526cfCompareSign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The weakness of fibers is their stack usage, and the main issue is stack overflows. With the current lack of stack overflow checking, it is extremely easy to write code that silently overflows the stack and causes all sorts of issues. Particularly when the overflow only happens in occasionally, this can lead to a horrible debug experience.
Sadly this will increase switching times a bit, but there's really no point to not checking stack overflows, it's the core problem with stackful scheduling.
After this feature, I would consider fibers to be ready for prime time, and I would deprecate protothreads/resumables not running in fiber mode (in a separate PR). Otherwise we'll never get past GCC12.
modm_context_jump