Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

[board] Add Adafruit Feather M4 Express BSP and examples#1032

Merged
salkinium merged 5 commits intomodm-io:developfromunknown repositoryJun 8, 2023
Merged

[board] Add Adafruit Feather M4 Express BSP and examples#1032

salkinium merged 5 commits intomodm-io:developfromunknown repositoryJun 8, 2023

Conversation

ghost
Copy link

Adafruit Feather M4 Express BSP and examples

@salkiniumsalkinium added this to the2023q2 milestoneJun 2, 2023
@salkiniumsalkinium self-requested a reviewJune 2, 2023 19:52
@salkiniumsalkinium changed the titleFeature/board feather m4[board] Add Adafruit Feather M4 Express BSP and examplesJun 2, 2023
@chris-durandchris-durand self-requested a reviewJune 3, 2023 19:45
Copy link
Member

@chris-durandchris-durand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks!

The board needs to be addedhere that the examples are compiled in the CI run.

Also, please runpython3 tools/scripts/synchronize_docs.py in the modm top level folder and commit the updatedREADME.md file.

@ghost
Copy link
Author

I ran "synchronize_docs.py", committed and pushed README.md. Then I spotted a typo in that file, and changed "you specific needs" to "your specific needs", committed and pushed it. Big mistake, I guess. Now it appears it's failing the test at that point. I tried to undo it from my local repo but have run into a "divergent branch" situation that I'm unsure how to fix. I don't believe there's really anything wrong with the file.

Copy link
Member

@salkiniumsalkinium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'm happy with this, thanks!

Copy link
Member

@chris-durandchris-durand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks!

@ghost
Copy link
Author

Thanks to your both for your patience! I now understand the process somewhat better, although I am still not friends with git just yet :-)
This is a great project, hope to do more in the future!

salkinium reacted with hooray emojisalkinium reacted with heart emoji

@salkinium
Copy link
Member

I've squashed and rebased your commits and will merge after the CI passes. Thanks!

@salkiniumsalkinium merged commit81b86be intomodm-io:developJun 8, 2023
@ghost ghost deleted the feature/board_feather_m4 branchJune 8, 2023 14:46
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Milestone
2023q2
Development

Successfully merging this pull request may close these issues.

2 participants
@salkinium@chris-durand

[8]ページ先頭

©2009-2025 Movatter.jp