Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

FEAT-#7401: Implement DataFrame/Series.attrs#7402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
noloerino wants to merge1 commit intomodin-project:main
base:main
Choose a base branch
Loading
fromnoloerino:joshi/7401-attrs

Conversation

@noloerino
Copy link
Collaborator

What do these changes do?

[STILL A DRAFT] Implement df.attrs by annotating relevant functions with a new @propagate_self_attrs annotation that automatically copiesself._attrs if the result is detected to be a new DataFrame/Series.

  • first commit message and PR title follow format outlinedhere

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passesflake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passesblack --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit withgit commit -s
  • ResolvesBUG: Writes toDataFrame.attrs are not preserved #7401
  • tests added and passing
  • module layout described atdocs/development/architecture.rst is up-to-date

Signed-off-by: Jonathan Shi <jhshi07@gmail.com>

importabc
importcopy
importfunctools

Check notice

Code scanning / CodeQL

Module is imported with 'import' and 'import from'

Module 'functools' is imported with both 'import' and 'import from'.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@devin-petersohndevin-petersohnAwaiting requested review from devin-petersohndevin-petersohn will be requested when the pull request is marked ready for reviewdevin-petersohn is a code owner

@mvashishthamvashishthaAwaiting requested review from mvashishthamvashishtha will be requested when the pull request is marked ready for reviewmvashishtha is a code owner

@RehanSDRehanSDAwaiting requested review from RehanSDRehanSD will be requested when the pull request is marked ready for reviewRehanSD is a code owner

@YarShevYarShevAwaiting requested review from YarShevYarShev will be requested when the pull request is marked ready for reviewYarShev is a code owner

@vnlitvinovvnlitvinovAwaiting requested review from vnlitvinovvnlitvinov will be requested when the pull request is marked ready for reviewvnlitvinov is a code owner

@anmyachevanmyachevAwaiting requested review from anmyachevanmyachev will be requested when the pull request is marked ready for reviewanmyachev is a code owner

@dchigarevdchigarevAwaiting requested review from dchigarevdchigarev will be requested when the pull request is marked ready for reviewdchigarev is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

BUG: Writes toDataFrame.attrs are not preserved

1 participant

@noloerino
[8]ページ先頭
©2009-2025 Movatter.jp