Commit99037af

sfc-gh-jkew

and

sfc-gh-mvashishtha

authored

TEST-#7686: Fix comparisons in caster tests to check the backend instead of type (#7687)

Originally the tests in `test_compiler_caster.py` only tested againstquery compilers; so checking that a cast occurred correctly wasperformed with an assert similar to `assert type(qc1) == type(qc2)`.Eventually the changes were lifted up into the DataFrame object so theseasserts became invalid although they continued to pass. A recent test,`test_merge_in_place` was added recently where I accidentally used theold pattern. While fixing this I also discovered that`test_information_asymmetry` was also still using the old style.- [x] first commit message and PR title follow format outlined[here](https://modin.readthedocs.io/en/latest/development/contributing.html#commit-message-formatting)> **_NOTE:_** If you edit the PR title to match this format, you need toadd another commit (even if it's empty) or amend your last commit forthe CI job that checks the PR title to pick up the new PR title.- [x] passes `flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py`- [x] passes `black --check modin/ asv_bench/benchmarksscripts/doc_checker.py`- [x] signed commit with `git commit -s` - [x]Resolves#7686 - [x] tests added and passing- [x] module layout described at `docs/development/architecture.rst` isup-to-date ---------Co-authored-by: Mahesh Vashishtha <mahesh.vashishtha@snowflake.com>

1 parent4d28700 commit99037afCopy full SHA for 99037af

File tree

1 file changed

-5

lines changed

modin/tests/pandas/native_df_interoperability
- test_compiler_caster.py

1 file changed

-5

lines changed

`‎modin/tests/pandas/native_df_interoperability/test_compiler_caster.py‎`

Lines changed: 5 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -711,7 +711,7 @@ def test_merge_in_place(default_df, lazy_df, cloud_df):`
`711`	`711`	`lazy_df=lazy_df.move_to("Lazy")`
`712`	`712`	`cloud_df=cloud_df.move_to("Cloud")`
`713`	`713`	`df=cloud_df.merge(lazy_df)`
`714`		`-asserttype(df)istype(cloud_df)`
	`714`	`+assertdf.get_backend()==cloud_df.get_backend()`
`715`	`715`	`assertlazy_df.get_backend()=="Lazy"`
`716`	`716`	`assertcloud_df.get_backend()=="Cloud"`
`717`	`717`
`@@ -722,15 +722,15 @@ def test_information_asymmetry(default_df, cloud_df, eager_df, lazy_df):`
`722`	`722`	`# the other way around, eager has a special ability to`
`723`	`723`	`# control the directionality of the cast.`
`724`	`724`	`df=default_df.merge(eager_df)`
`725`		`-asserttype(df)istype(eager_df)`
	`725`	`+assertdf.get_backend()==eager_df.get_backend()`
`726`	`726`	`df=cloud_df.merge(eager_df)`
`727`		`-asserttype(df)istype(eager_df)`
	`727`	`+assertdf.get_backend()==eager_df.get_backend()`
`728`	`728`
`729`	`729`	`# lazy_df tries to pawn off work on other engines`
`730`	`730`	`df=default_df.merge(lazy_df)`
`731`		`-asserttype(df)istype(default_df)`
	`731`	`+assertdf.get_backend()==default_df.get_backend()`
`732`	`732`	`df=cloud_df.merge(lazy_df)`
`733`		`-asserttype(df)istype(cloud_df)`
	`733`	`+assertdf.get_backend()==cloud_df.get_backend()`
`734`	`734`
`735`	`735`
`736`	`736`	`deftest_setitem_in_place_with_self_switching_backend(cloud_df,local_df):`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit99037af

File tree

1 file changed

1 file changed

`‎modin/tests/pandas/native_df_interoperability/test_compiler_caster.py‎`

0 commit comments