- Notifications
You must be signed in to change notification settings - Fork2.1k
tests: useinline_snapshot.Is
on parametrized test#945
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation
agronholm commentedJun 12, 2025
Looks like the tests are still failing though? |
agronholm commentedJun 12, 2025
That one failure looks like just a flaky test. |
Kludex commentedJun 12, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Now the test is fixed... But it's failing correctly... 😅 The |
Viicos commentedJun 12, 2025
In progress inpydantic/pydantic-core#1719, but anyway this will only be included in 2.12. |
agronholm commentedJun 12, 2025
If you access the MCP server without the trailing slash, it will redirect you to a URL with the slash added. |
Are you saying this is working as expected? |
agronholm commentedJun 12, 2025
I have no idea how the test is supposed to work, TBH. I just observed a lot of redirects happening in the test suite when the forward slash is missing from the end of the URI. |
It's a Starlette thing. There's another PR that fixes the redirect behavior. |
@Kludex With
I think it's better to edit it to make it compatible with newer |
agronholm commentedJun 23, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@medaminezghal my Trio PR (#946) fixes that too. Right now this PR is the only thing in this code base standing between me and a fully passing test suite. |
agronholm commentedJun 23, 2025
That SSE failure could be due to improperly nested async context managers (typically a stream closed before the task using it has finished) |
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks good. |
4a6fbd3
to62f114f
Comparetook the liberty of rebasing - looks like |
62f114f
to84937d1
Compare95b44fb
intomainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
cc@agronholm
This PR just uses
inline_snapshot
s properly on a parametrized test.