Commit7e940ba

committed

Auto merge ofrust-lang#126578 - scottmcm:inlining-bonuses-too, r=davidtwco

Account for things that optimize out in inlining costsThis updates the MIR inlining `CostChecker` to have both bonuses and penalties, rather than just penalties.That lets us add bonuses for some things where we want to encourage inlining without risking wrapping into a gigantic cost. For example, `switchInt(const …)` we give an inlining bonus because codegen will actually eliminate the branch (and associated dead blocks) once it's monomorphized, so measuring both sides of the branch gives an unrealistically-high cost to it. Similarly, an `unreachable` terminator gets a small bonus, because whatever branch leads there doesn't actually exist post-codegen.

2 parents9a945fd +847726d commit7e940baCopy full SHA for 7e940ba

File tree

1 file changed

-2

lines changed

core/src/slice/iter
- macros.rs

1 file changed

-2

lines changed

`‎core/src/slice/iter/macros.rs‎`

Lines changed: 4 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -103,7 +103,8 @@ macro_rules! iterator {`
`103`	`103`	// so this new pointer is inside `self` and thus guaranteed to be non-null.
`104`	`104`	`unsafe{`
`105`	`105`	`if_zst!(mutself,`
`106`		`- len =>*len = len.unchecked_sub(offset),`
	`106`	`+// Using the intrinsic directly avoids emitting a UbCheck`
	`107`	`+ len =>len =crate::intrinsics::unchecked_sub(len, offset),`
`107`	`108`	`_end =>self.ptr =self.ptr.add(offset),`
`108`	`109`	`);`
`109`	`110`	`}`
`@@ -119,7 +120,8 @@ macro_rules! iterator {`
`119`	`120`	// SAFETY: By our precondition, `offset` can be at most the
`120`	`121`	`// current length, so the subtraction can never overflow.`
`121`	`122`	`len =>unsafe{`
`122`		`-*len = len.unchecked_sub(offset);`
	`123`	`+// Using the intrinsic directly avoids emitting a UbCheck`
	`124`	`+len =crate::intrinsics::unchecked_sub(len, offset);`
`123`	`125`	`self.ptr`
`124`	`126`	`},`
`125`	`127`	// SAFETY: the caller guarantees that `offset` doesn't exceed `self.len()`,

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit7e940ba

File tree

1 file changed

1 file changed

`‎core/src/slice/iter/macros.rs‎`

0 commit comments