Commit1069a68

committed

core: VaArgSafe is an unsafe trait

`T: VaArgSafe` is relied on for soundness. Safe impls promise nothing.Therefore this must be an unsafe trait. Slightly pedantic, asonly core can impl this, but we could choose to unseal the trait.That would allow soundly (but unsafely) implementing this for e.g.a `#[repr(C)] struct` that should be passable by varargs.

1 parente51d8a2 commit1069a68Copy full SHA for 1069a68

File tree

1 file changed

-4

lines changed

core/src/ffi
- mod.rs

1 file changed

-4

lines changed

`‎core/src/ffi/mod.rs‎`

Lines changed: 5 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -484,7 +484,7 @@ mod sealed_trait {`
`484`	`484`	`all supported platforms",`
`485`	`485`	`issue ="44930"`
`486`	`486`	`)]`
`487`		`-pubtraitVaArgSafe{}`
	`487`	`+pubunsafetraitVaArgSafe{}`
`488`	`488`	`}`
`489`	`489`
`490`	`490`	`macro_rules! impl_va_arg_safe{`
`@@ -494,7 +494,7 @@ macro_rules! impl_va_arg_safe {`
`494`	`494`	reason ="the `c_variadic` feature has not been properly tested on\
`495`	`495`	`all supported platforms",`
`496`	`496`	`issue ="44930")]`
`497`		`-impl sealed_trait::VaArgSafefor $t{}`
	`497`	`+unsafeimpl sealed_trait::VaArgSafefor $t{}`
`498`	`498`	`)+`
`499`	`499`	`}`
`500`	`500`	`}`
`@@ -509,14 +509,15 @@ impl_va_arg_safe! {f64}`
`509`	`509`	`all supported platforms",`
`510`	`510`	`issue ="44930"`
`511`	`511`	`)]`
`512`		`-impl<T> sealed_trait::VaArgSafefor*mutT{}`
	`512`	`+unsafeimpl<T> sealed_trait::VaArgSafefor*mutT{}`
	`513`	`+`
`513`	`514`	`#[unstable(`
`514`	`515`	`feature ="c_variadic",`
`515`	`516`	reason ="the `c_variadic` feature has not been properly tested on\
`516`	`517`	`all supported platforms",`
`517`	`518`	`issue ="44930"`
`518`	`519`	`)]`
`519`		`-impl<T> sealed_trait::VaArgSafefor*constT{}`
	`520`	`+unsafeimpl<T> sealed_trait::VaArgSafefor*constT{}`
`520`	`521`
`521`	`522`	`#[unstable(`
`522`	`523`	`feature ="c_variadic",`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit1069a68

File tree

1 file changed

1 file changed

`‎core/src/ffi/mod.rs‎`

0 commit comments