- Notifications
You must be signed in to change notification settings - Fork169
feat: add popover introduction info for models#63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Neet-Nestor left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks for the contribution! It looks fine on my end, but for style consistency and package size we tend to not introduce additional packages, especially large ones like material UI unless absolute necessary.
For the popover you used, we have a nativePopover implementation atui-lib.js already. Could you try adopting it to see whether it is working? If so we can avoid introducing both emotion and material UI here.
New feature: added a popover introduction for home screen's model selector, include info for each model's size, author, quantization, Vram required and more.
Desktop.2024.09.09.-.01.11.28.02.mp4