Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: add popover introduction info for models#63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
JiaxinD wants to merge1 commit intomlc-ai:main
base:main
Choose a base branch
Loading
fromJiaxinD:jd

Conversation

@JiaxinD
Copy link

New feature: added a popover introduction for home screen's model selector, include info for each model's size, author, quantization, Vram required and more.

Desktop.2024.09.09.-.01.11.28.02.mp4

@Neet-NestorNeet-Nestor self-requested a reviewSeptember 10, 2024 16:21
Copy link
Collaborator

@Neet-NestorNeet-Nestor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for the contribution! It looks fine on my end, but for style consistency and package size we tend to not introduce additional packages, especially large ones like material UI unless absolute necessary.

For the popover you used, we have a nativePopover implementation atui-lib.js already. Could you try adopting it to see whether it is working? If so we can avoid introducing both emotion and material UI here.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@Neet-NestorNeet-NestorNeet-Nestor requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JiaxinD@Neet-Nestor

[8]ページ先頭

©2009-2025 Movatter.jp