- Notifications
You must be signed in to change notification settings - Fork178
cosmetic changes#175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
cosmetic changes#175
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View thisfailed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
@mitchspano I know this is a lame PR, but my next one will involve an option to debug limits in an execution. |
This is a very large PR. Can we break it down into smaller changes? |
@mitchspano Done. This is now cosmetic plus an update to the workflow to use I can't tell if the documentation in |
...fault/objects/sObject_Trigger_Setting__mdt/fields/TriggerRecord_Class_Name__c.field-meta.xml OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
Docs are auto-generated. Those should be left alone. |
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
.prettierrc Outdated
| }, | ||
| { | ||
| "files": "*.trigger", | ||
| "options": { "printWidth": 200 } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Why is this different than the other print width specification
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
When the width is less than 200, all the trigger contexts listed go one above each other on separate lines, making it unnecessarily harder (at least for me) to understand. However, since there are no triggers in this project, I can remove it.
| @@ -1,15 +1,81 @@ | |||
| { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
What is the source of all of this customization in this file?
The standard config is availablehere. I see advantage in specifyingapexInsertFinalNewline : false, but the rest of the stuff seems to be the project-specific configuration from another team's project.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This is the file I use for my projects - it has more granular items from my experiences. For example, the space before the closing/> on the top line of metadata files now won't trigger a whitespace change if the metadata is downloaded from the org.
Uh oh!
There was an error while loading.Please reload this page.