Commite9126fd

authored and

committed

pythongh-97943: PyFunction_GetAnnotations should return a borrowed reference. (pythonGH-97949)

(cherry picked from commit6bfb0be)Co-authored-by: larryhastings <larry@hastings.org>

1 parent6057030 commite9126fdCopy full SHA for e9126fd

File tree

-2

lines changed

-2

lines changed

Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,2 @@`
	`1`	+Bugfix::func:`PyFunction_GetAnnotations` should return a borrowed
	`2`	`+reference. It was returning a new reference.`

Lines changed: 5 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -300,7 +300,6 @@ func_get_annotation_dict(PyFunctionObject *op)`
`300`	`300`	`}`
`301`	`301`	`Py_SETREF(op->func_annotations,ann_dict);`
`302`	`302`	`}`
`303`		`-Py_INCREF(op->func_annotations);`
`304`	`303`	`assert(PyDict_Check(op->func_annotations));`
`305`	`304`	`returnop->func_annotations;`
`306`	`305`	`}`
`@@ -532,7 +531,11 @@ func_get_annotations(PyFunctionObject op, void Py_UNUSED(ignored))`
`532`	`531`	`if (op->func_annotations==NULL)`
`533`	`532`	`returnNULL;`
`534`	`533`	`}`
`535`		`-returnfunc_get_annotation_dict(op);`
	`534`	`+PyObject*d=func_get_annotation_dict(op);`
	`535`	`+if (d) {`
	`536`	`+Py_INCREF(d);`
	`537`	`+ }`
	`538`	`+returnd;`
`536`	`539`	`}`
`537`	`540`
`538`	`541`	`staticint`

Comments

(0)