Commit44659d3

and

authored

pythonGH-118943: Handle races when moving jit_stencils.h (pythonGH-120690)

Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru>

1 parent5bd7291 commit44659d3Copy full SHA for 44659d3

File tree

-1

lines changed

-1

lines changed

Lines changed: 3 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+Fix a possible race condition affecting parallel builds configured with`
	`2`	+``--enable-experimental-jit``, in which:exc:`FileNotFoundError` could be caused by
	`3`	+another process already moving ``jit_stencils.h.new`` to ``jit_stencils.h``.

Lines changed: 6 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -221,7 +221,12 @@ def build(`
`221`	`221`	`file.write("\n")`
`222`	`222`	`forlinein_writer.dump(stencil_groups):`
`223`	`223`	`file.write(f"{line}\n")`
`224`		`-jit_stencils_new.replace(jit_stencils)`
	`224`	`+try:`
	`225`	`+jit_stencils_new.replace(jit_stencils)`
	`226`	`+exceptFileNotFoundError:`
	`227`	`+# another process probably already moved the file`
	`228`	`+ifnotjit_stencils.is_file():`
	`229`	`+raise`
`225`	`230`	`finally:`
`226`	`231`	`jit_stencils_new.unlink(missing_ok=True)`
`227`	`232`

Comments

(0)