Nov 20, 2025 · Nov 20, 2025
diff --git a/cmd/xl-storage.go b/cmd/xl-storage.go
 if skipParent == "" {
 skipParent = s.drivePath
 }
 // Create top level directories if they don't exist.
 // with mode 0777 mkdir honors system umask.
 if err = mkdirAll(pathutil.Dir(filePath), 0o777, skipParent); err != nil {
 return nil, osErrToFileErr(err)
 }

 w, err := OpenFile(filePath, mode, 0o666)
 if err != nil && os.IsNotExist(err) {
 // Write likely failed because the parent directory does not
 // exist. Attempt to create top-level directories with mode
 // 0777 and retry the write.
 if e1 := mkdirAll(pathutil.Dir(filePath), 0o777, skipParent); e1 != nil {
 return nil, osErrToFileErr(e1)
 }
 w, err = OpenFile(filePath, mode, 0o666)
 }
 if err != nil {
 // File path cannot be verified since one of the parents is a file.
 switch {
diff --git a/cmd/xl-storage_test.go b/cmd/xl-storage_test.go
 t.Fatalf("Unexpected error from readMetadata - expect %v: got %v", errFileNameTooLong, err)
 }
 }

 // TestXLStorage xlStorage.AppendFile() - benchmark performance of a zero length write.
 // This benchmark is mostly designed to bench the performance of all of the setup code
 // performed around the AppendFile and openFile methods.
 func BenchmarkXLStorageAppendFile(b *testing.B) {
 // create xlStorage
 xlStorage, path, err := newXLStorageTestSetup(b)
 if err != nil {
 b.Fatalf("Unable to create xlStorage test setup, %s", err)
 }

 // Setup environment.
 if err = xlStorage.MakeVol(b.Context(), "success-vol"); err != nil {
 b.Fatalf("Unable to create volume, %s", err)
 }

 // Create directory to make errIsNotRegular
 if err = os.Mkdir(slashpath.Join(path, "success-vol", "object-as-dir"), 0o777); err != nil {
 b.Fatalf("Unable to create directory, %s", err)
 }
 b.ResetTimer()

 fileName := "path/to/my/object"
 data := []byte{}
 for i := 0; i < b.N; i++ {
 err := xlStorage.AppendFile(b.Context(), "success-vol", fileName, data)
 if err != nil {
 b.Fatal(err)
 }
 }
 }
Original file line number	Diff line number	Diff line change
Expand Up		@@ -1980,13 +1980,17 @@ func (s xlStorage) openFile(filePath string, mode int, skipParent string) (f o
		if skipParent == "" {
		skipParent = s.drivePath
		}
		// Create top level directories if they don't exist.
		// with mode 0777 mkdir honors system umask.
		if err = mkdirAll(pathutil.Dir(filePath), 0o777, skipParent); err != nil {
		return nil, osErrToFileErr(err)
		}

		w, err := OpenFile(filePath, mode, 0o666)
		if err != nil && os.IsNotExist(err) {
		// Write likely failed because the parent directory does not
		// exist. Attempt to create top-level directories with mode
		// 0777 and retry the write.
		if e1 := mkdirAll(pathutil.Dir(filePath), 0o777, skipParent); e1 != nil {
		return nil, osErrToFileErr(e1)
		}
		w, err = OpenFile(filePath, mode, 0o666)
		}
		if err != nil {
		// File path cannot be verified since one of the parents is a file.
		switch {
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -1941,3 +1941,34 @@ func TestXLStorageReadMetadata(t *testing.T) {
		t.Fatalf("Unexpected error from readMetadata - expect %v: got %v", errFileNameTooLong, err)
		}
		}

		// TestXLStorage xlStorage.AppendFile() - benchmark performance of a zero length write.
		// This benchmark is mostly designed to bench the performance of all of the setup code
		// performed around the AppendFile and openFile methods.
		func BenchmarkXLStorageAppendFile(b *testing.B) {
		// create xlStorage
		xlStorage, path, err := newXLStorageTestSetup(b)
		if err != nil {
		b.Fatalf("Unable to create xlStorage test setup, %s", err)
		}

		// Setup environment.
		if err = xlStorage.MakeVol(b.Context(), "success-vol"); err != nil {
		b.Fatalf("Unable to create volume, %s", err)
		}

		// Create directory to make errIsNotRegular
		if err = os.Mkdir(slashpath.Join(path, "success-vol", "object-as-dir"), 0o777); err != nil {
		b.Fatalf("Unable to create directory, %s", err)
		}
		b.ResetTimer()

		fileName := "path/to/my/object"
		data := []byte{}
		for i := 0; i < b.N; i++ {
		err := xlStorage.AppendFile(b.Context(), "success-vol", fileName, data)
		if err != nil {
		b.Fatal(err)
		}
		}
		}