- Notifications
You must be signed in to change notification settings - Fork6.5k
helm: Add warning when existingClaim is ignored in distributed mode#21689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
sirzzang wants to merge1 commit intominio:masterChoose a base branch fromsirzzang:helm/warinig-existingclaim-distributed
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
+20 −0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
- Add conditional warning in NOTES.txt when mode=distributed and persistence.existingClaim is set- Enhance values.yaml documentation to clarify existingClaim limitation- Help users understand PVC behavior in different modesDistributed mode requires multiple PVCs via volumeClaimTemplates forerasure coding. existingClaim only works in standalone mode.Fixes user confusion when their specified PVC is silently ignored.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Community Contribution License
All community contributions in this pull request are licensed to the project maintainers
under the terms of theApache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.
Description
Adds a user-friendly warning message when
persistence.existingClaimis set but will be ignored due to distributed mode deployment.Motivation and Context
Problem Statement
Users frequently configure
persistence.existingClaimexpecting it to work in distributed mode, but this parameter is silently ignored because:volumeClaimTemplatesexistingClaimThis leads to:
/var/lib/rancher/k3s/storagein K3s)Real-world example:
I deployed MinIO with a custom PVC pointing to an SSD I had mounted at
/mnt/data. However, in distributed mode, myexistingClaimwas silently ignored, and MinIO ended up filling the root partition (/var/lib/rancher/k3s/storage) instead, causing system issues.Solution
Changes Made
NOTES.txt: Added conditional warning block that displays when:
mode: distributedANDpersistence.existingClaimis setvalues.yaml: Enhanced documentation with clear warning comment explaining the limitation
User guidance: Provides actionable solutions:
Warning Message Preview
How to test this PR?
Helm Lint
$ helm lint helm/minio==> Linting helm/minio1 chart(s) linted, 0 chart(s) failed ✅Test Cases
mode=distributed+existingClaim=my-pvcmode=standalone+existingClaim=my-pvcmode=distributed(no existingClaim)mode=standalone+storageClass=local-pathTest Commands Used
Types of changes
Checklist:
commit-idorPR #here)