Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

helm: Add warning when existingClaim is ignored in distributed mode#21689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
sirzzang wants to merge1 commit intominio:master
base:master
Choose a base branch
Loading
fromsirzzang:helm/warinig-existingclaim-distributed

Conversation

@sirzzang
Copy link

@sirzzangsirzzang commentedNov 12, 2025
edited
Loading

Community Contribution License

All community contributions in this pull request are licensed to the project maintainers
under the terms of theApache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.

Description

Adds a user-friendly warning message whenpersistence.existingClaim is set but will be ignored due to distributed mode deployment.

Motivation and Context

Problem Statement

Users frequently configurepersistence.existingClaim expecting it to work in distributed mode, but this parameter is silently ignored because:

  • Distributed mode uses StatefulSet'svolumeClaimTemplates
  • Multiple PVCs are required for erasure coding (minimum 4)
  • Only a single PVC can be specified viaexistingClaim

This leads to:

  • User confusion when their custom PVC is not used
  • Unexpected fallback to default StorageClass (e.g.,/var/lib/rancher/k3s/storage in K3s)
  • Difficult debugging with no feedback about ignored configuration
  • Potential disk space issues on wrong partitions

Real-world example:
I deployed MinIO with a custom PVC pointing to an SSD I had mounted at/mnt/data. However, in distributed mode, myexistingClaim was silently ignored, and MinIO ended up filling the root partition (/var/lib/rancher/k3s/storage) instead, causing system issues.

Solution

Changes Made

  1. NOTES.txt: Added conditional warning block that displays when:

    • mode: distributed AND
    • persistence.existingClaim is set
  2. values.yaml: Enhanced documentation with clear warning comment explaining the limitation

  3. User guidance: Provides actionable solutions:

    • Switch to standalone mode to use existingClaim
    • Use distributed mode with custom StorageClass

Warning Message Preview

WARNING: persistence.existingClaim is set but will be ignored in distributed mode.In distributed mode, MinIO automatically creates multiple PersistentVolumeClaimsusing StatefulSet's volumeClaimTemplates for erasure coding.Your specified PVC 'my-custom-pvc' will not be used.To use your existing PVC:  - Switch to standalone mode: --set mode=standaloneTo use distributed mode with custom storage:  - Specify a StorageClass: --set persistence.storageClass=<your-storage-class>For more information:https://github.com/minio/minio/tree/master/helm/minio#distributed-vs-standalone

How to test this PR?

Helm Lint

$ helm lint helm/minio==> Linting helm/minio1 chart(s) linted, 0 chart(s) failed ✅

Test Cases

ScenarioExpectedResult
mode=distributed +existingClaim=my-pvc⚠️ Warning shown✅ Pass
mode=standalone +existingClaim=my-pvcNo warning✅ Pass
mode=distributed (no existingClaim)No warning✅ Pass
mode=standalone +storageClass=local-pathNo warning✅ Pass

Test Commands Used

# Warning appears correctlyhelm templatetest helm/minio \  --set mode=distributed \  --set persistence.existingClaim=my-pvc \  --show-only templates/NOTES.txt# No warning in standalone modehelm templatetest helm/minio \  --set mode=standalone \  --set persistence.existingClaim=my-pvc \  --show-only templates/NOTES.txt# Lint passeshelm lint helm/minio \  --set mode=distributed \  --set persistence.existingClaim=my-pvc

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please addcommit-id orPR # here)
  • Unit tests added/updated
  • Internal documentation updated
  • Create a documentation update requesthere

- Add conditional warning in NOTES.txt when mode=distributed and  persistence.existingClaim is set- Enhance values.yaml documentation to clarify existingClaim limitation- Help users understand PVC behavior in different modesDistributed mode requires multiple PVCs via volumeClaimTemplates forerasure coding. existingClaim only works in standalone mode.Fixes user confusion when their specified PVC is silently ignored.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@sirzzang

[8]ページ先頭

©2009-2025 Movatter.jp