Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork114
Dependency Upgrades | globals 16.x#1448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
mikepenz commentedMar 28, 2025
- upgrade node dependencies
- dev dependencies
``` globals ^15.15.0 → ^16.0.0```- dev dependencies``` @eslint/eslintrc ^3.2.0 → ^3.3.1 @eslint/js ^9.20.0 → ^9.23.0 @types/node ^22.13.4 → ^22.13.14 @types/semver ^7.5.8 → ^7.7.0 @typescript-eslint/eslint-plugin ^8.24.1 → ^8.28.0 @typescript-eslint/parser ^8.24.1 → ^8.28.0 eslint ^9.20.1 → ^9.23.0 eslint-import-resolver-typescript ^3.8.1 → ^4.2.5 eslint-plugin-github ^5.1.8 → ^6.0.0 eslint-plugin-prettier ^5.2.3 → ^5.2.5 prettier 3.5.1 → 3.5.3 ts-jest ^29.2.5 → ^29.3.0 typescript ^5.7.3 → ^5.8.2```
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Pull Request Overview
This pull request upgrades several dependencies, including globals to 16.x and assorted ESLint and TypeScript tooling. Key changes include updating lint disable comments in the repository code, modifying the ESLint configuration to integrate the new github plugin version, and refreshing copyright metadata.
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/repositories/GithubRepository.ts | Removed a lint rule disable for "github/array-foreach" on a forEach loop usage |
| eslint.config.mjs | Added an import for the github plugin and adjusted the plugins configuration block |
| README.md | Updated the copyright year to 2025 |
Files not reviewed (1)
- package.json: Language not supported
Comments suppressed due to low confidence (2)
src/repositories/GithubRepository.ts:251
- Verify that the removal of the 'github/array-foreach' disable comment is intentional. If this rule is still applicable to the code style enforced by the new dependency versions, consider either reintroducing it or refactoring the code accordingly.
// eslint-disable-next-line @typescript-eslint/no-explicit-anyeslint.config.mjs:21
- It appears that the spread of 'compat.extends("plugin:github/recommended")' has been removed from the ESLint configuration. Confirm that this removal was deliberate, as it may result in missing recommended rules from the github plugin.
}, {809d48d intodevelopUh oh!
There was an error while loading.Please reload this page.