- Notifications
You must be signed in to change notification settings - Fork340
Exclude .signature.p7s from nupkg file count#10418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
ContributorAuthor
ellahathaway commentedNov 7, 2024
@nohwnd - can I please get your review on this? Pinging because I'm unable to add you as a reviewer to the PR. Thanks in advance! |
nohwnd approved these changesNov 7, 2024
Member
nohwnd commentedNov 7, 2024
Looks great. Feel free to ping also next time, it is more effective :) |
3269845 intomicrosoft:main 7 checks passed
Uh oh!
There was an error while loading.Please reload this page.
This was referencedFeb 20, 2025
This was referencedJul 21, 2025
Closed
This was referencedNov 24, 2025
Merged
Open
Open
Open
Bump Microsoft.NET.Test.Sdk from 16.9.4 to 17.13.0amusha1981/skills-secure-repository-supply-chain#8
Open
Open
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#10414
This PR adds logic to exclude
.signature.p7sfiles from the file count when verifying nupkgs inverify-nupkgs.ps1. This allows the verification to still pass when the artifacts are signed.