microsoft/vscode-python-environmentsPublic

NotificationsYou must be signed in to change notification settings
Fork15
Star52

Handle all shells’ de/activation#137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

karthiknadig merged 4 commits intomicrosoft:mainfromflying-sheep:pa/all-shells

Jan 27, 2025

Merged

Handle all shells’ de/activation#137

karthiknadig merged 4 commits intomicrosoft:mainfromflying-sheep:pa/all-shells

Jan 27, 2025

Conversation

Copy link

Contributor

flying-sheep commentedJan 24, 2025•
edited
Loading

Fixes#138

This adds shell activation for

gitbash
wsl
ksh
tcshell
xonsh
nushell

and fixes shell activation for C shell.

it also makes sure that it’s impossible to add a terminal to the enum without also adding shell activation/deactivation commands by using aRecord type that needs to be exhaustive.

Handle all shells’ de/activation

1a0c788

flying-sheep commented

Jan 24, 2025

View reviewed changes

src/managers/builtin/venvUtils.tsShow resolvedHide resolved

src/managers/builtin/venvUtils.ts OutdatedShow resolvedHide resolved

flying-sheep mentioned this pull request

Jan 24, 2025

Use shell type API from core to detect shell type#116

Closed

add unknown to Record

9bbe73e

Copy link

Member

karthiknadig commentedJan 24, 2025

Thanks for the PR! Love the new shell command handling.

flying-sheep added2 commits

January 25, 2025 11:39

check all virtualenv shells

007f37e

more explicit

316cd2d

karthiknadigenabled auto-merge (squash)

January 25, 2025 18:52

karthiknadig requested review fromeleanorjboyd andanthonykim1

January 25, 2025 22:28

Copy link

Contributor

anthonykim1 commentedJan 27, 2025•
edited
Loading

Thanks for doing this@flying-sheep
I mentioned#116, we should eventually start using shell type API.

The list onhttps://github.com/microsoft/vscode/blob/e8346324cfb8b5d680ad657bb67153eb838aebc5/src/vscode-dts/vscode.proposed.terminalShellType.d.ts are subject to change, so feel free to let me know if anyone thinks more shell types could be added to make the workload easier on the extension side. As we want to make sure to cover extensive list of shell types for their specific activation.