- Notifications
You must be signed in to change notification settings - Fork58
Make "args": "${command:pickArgs}" as default debug configuration#548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
@microsoft-github-policy-service agree |
karthiknadig approved these changesJan 16, 2025
eleanorjboyd approved these changesFeb 14, 2025
4d27e65 intomicrosoft:main 16 checks passed
Uh oh!
There was an error while loading.Please reload this page.
eleanorjboyd added a commit to eleanorjboyd/vscode-python-debugger that referenced this pull requestFeb 14, 2025
…crosoft#548)Co-authored-by: Eleanor Boyd <26030610+eleanorjboyd@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is related to these issues:
microsoft/vscode#225834
microsoft/vscode#232560
#233
#465
#497
I searched
repo:microsoft/vscode-python-debugger command:pickArgsfiltered by code, and find four snippet in thee files.vscode-python-debugger/src/extension/debugger/configuration/providers/fileLaunchWithArgs.ts
Lines 21 to 27 in1b6ac0d
vscode-python-debugger/src/test/unittest/configuration/providers/fileLaunchWithArgs.unit.test.ts
Lines 28 to 34 in1b6ac0d
vscode-python-debugger/package.json
Lines 286 to 306 in1b6ac0d
In lines 286 to 306 of
package.json, it shows three usages of theargsparameter. The first is that the value of theargsparameter is "${command:pickArgs}", the second is to provide an array, and the third is to provide a string.In thevscode documentation, it is also mentioned:
Therefore, I think the two files
fileLaunchWithArgs.tsandfileLaunchWithArgs.unit.test.tsare the key factors affecting this problem. Then I delete the [ ] in these two code snippets.When I wrote this PR, I checked the file modification history and found that the modification in PR#385 added [ ], but this was completely wrong (refer to the discussion of issue#497), and was not the correct way to solve issue#233 (PR#499 solved the problem), and led to a series of issues listed at the beginning.
Just consider this PR to have coincidentally performed a "revert" operation.