forked fromDonJayamanne/pythonVSCode
- Notifications
You must be signed in to change notification settings - Fork1.2k
Prefer using Notebook tools over Python tools for notebooks#25098
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
src/client/chat/utils.ts Outdated
| ); | ||
| } | ||
| throw new Error( | ||
| `This tool cannot be used for Jupyter Notebooks. Install the Jupyter Extension (${JUPYTER_EXTENSION_ID}) & try using notebook specific tools instead.`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@rebornix From my testing this works as expected.
roblourens approved these changesMay 21, 2025
8ae346b intomain 85 checks passed
Uh oh!
There was an error while loading.Please reload this page.
anthonykim1 pushed a commit to anthonykim1/vscode-python that referenced this pull requestJun 5, 2025
…t#25098)@karthiknadig@eleanorjboyd@rebornix@amunger This change will change how the Python tools work.The python tools will no longer work with Notebooks.Previously it would,From my testing, this change works perfectly well.I think thats fraught with danger. There are a lot of things toconsider.**Ideally there should ever be only one way of doing things, whether itslocal/remote/python/non-python notebooks.**
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
no-changelogNo news entry required skip package*.jsonpackage.json and package-lock.json don't both need updating skip testsUpdates to tests unnecessary skip-issue-check
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
@karthiknadig@eleanorjboyd@rebornix@amunger
This change will change how the Python tools work.
The python tools will no longer work with Notebooks.
Previously it would,
From my testing, this change works perfectly well.
I think thats fraught with danger. There are a lot of things to consider.
Ideally there should ever be only one way of doing things, whether its local/remote/python/non-python notebooks.