- Notifications
You must be signed in to change notification settings - Fork1.2k
Ability to track the user selected Environment#25090
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation
| ): Promise< | ||
| | { | ||
| environment: EnvironmentPath; | ||
| reason: 'globalUserSelected' | 'workspaceUserSelected' | 'defaultRecommended'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Providing the reasons why an environment is recommended.
| @@ -28,6 +33,9 @@ export class PythonPathUpdaterService implements IPythonPathUpdaterServiceManage | |||
| let failed = false; | |||
| try { | |||
| await pythonPathUpdater.updatePythonPath(pythonPath); | |||
| if (trigger === 'ui') { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I believe this is the right spot for tracking what env is selected by the user.
| @@ -67,7 +66,6 @@ export class InstallPackagesTool implements LanguageModelTool<IInstallPackageArg | |||
| for (const packageName of options.input.packageList) { | |||
| await installer.installModule(packageName, resourcePath, token, undefined, { installAsProcess: true }); | |||
| } | |||
| trackEnvUsedByTool(resourcePath, environment); | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Old code no longer required
d7a5ab7 intomainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
@karthiknadig /cc