Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

More specific llm tools#25072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
DonJayamanne merged 11 commits intomainfromdon/diplomatic-mink
May 16, 2025
Merged

More specific llm tools#25072

DonJayamanne merged 11 commits intomainfromdon/diplomatic-mink
May 16, 2025

Conversation

DonJayamanne
Copy link

No description provided.

@DonJayamanneDonJayamanne added no-changelogNo news entry required skip package*.jsonpackage.json and package-lock.json don't both need updating skip testsUpdates to tests unnecessary skip-issue-check labelsMay 15, 2025
},
"when": "!pythonEnvExtensionInstalled"
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Will disable listPythonPackages for now

karthiknadig reacted with thumbs up emoji
@@ -17,6 +17,7 @@ suite('Python Path Settings Updater', () => {
serviceContainer = TypeMoq.Mock.ofType<IServiceContainer>();
workspaceService = TypeMoq.Mock.ofType<IWorkspaceService>();
interpreterPathService = TypeMoq.Mock.ofType<IInterpreterPathService>();
experimentsManager = TypeMoq.Mock.ofType<IExperimentService>();
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Fix some errors in other parts of the code that ws causing issues

@@ -36,6 +37,11 @@ suite('Execution Flow Run Adapters', () => {
let useEnvExtensionStub: sinon.SinonStub;

setup(() => {
const proc = typeMoq.Mock.ofType<MockChildProcess>();
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Fix some errors in other parts of the code that ws causing issues

@@ -62,7 +62,7 @@ export async function updateSetting(
configTarget: ConfigurationTarget,
) {
const vscode = require('vscode') as typeof import('vscode');
const settings = vscode.workspace.getConfiguration('python', { uri: resource, languageId: 'python' } || null);
const settings = vscode.workspace.getConfiguration('python', { uri: resource, languageId: 'python' });
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

|| null was not required, as its impossible for object to be empty.
was getting these errors locally.

@DonJayamanneDonJayamanne marked this pull request as ready for reviewMay 15, 2025 23:50
@vs-code-engineeringvs-code-engineeringbot added this to theMay 2025 milestoneMay 15, 2025
@DonJayamanneDonJayamanne merged commit5045cdd intomainMay 16, 2025
85 checks passed
@DonJayamanneDonJayamanne deleted the don/diplomatic-mink branchMay 16, 2025 02:06
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@karthiknadigkarthiknadigkarthiknadig approved these changes

Assignees

@DonJayamanneDonJayamanne

Labels
no-changelogNo news entry requiredskip package*.jsonpackage.json and package-lock.json don't both need updatingskip testsUpdates to tests unnecessaryskip-issue-check
Projects
None yet
Milestone
May 2025
Development

Successfully merging this pull request may close these issues.

2 participants
@DonJayamanne@karthiknadig

[8]ページ先頭

©2009-2025 Movatter.jp