Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

PYTHONSTARTUP should be injected regardless of terminalEnv experiment#25037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

anthonykim1
Copy link

Resolve:#25013

Python shell integration env var injection via env var collection was getting cleared undesirable, when user had opted out of terminal env var experiment.

We want to inject PYTHONSTARTUP regardless of the experiment, depending on user setting.

@anthonykim1anthonykim1 added this to theMay 2025 milestoneMay 5, 2025
@anthonykim1anthonykim1 self-assigned thisMay 5, 2025
@anthonykim1anthonykim1 added bugIssue identified by VS Code Team member as probable bug area-terminal labelsMay 5, 2025
@anthonykim1anthonykim1 marked this pull request as draftMay 5, 2025 23:18
@anthonykim1
Copy link
Author

anthonykim1 commentedMay 5, 2025•
edited
Loading

Problem summary

  • PYTHONSTARTUP was getting injected, but was getting cleared undesirably conditionally on env var experiment state.

@anthonykim1anthonykim1 changed the titlePYTHONSTARTUP should be injected regardless of pythonTerminalEnv ExperimentPYTHONSTARTUP should be injected regardless of terminalEnv experimentMay 5, 2025
@anthonykim1anthonykim1 marked this pull request as ready for reviewMay 6, 2025 16:29
@vs-code-engineeringVS Code Engineering
Copy link

⚠️ This PR originates from a fork. Due to security restrictions, pipelines from forks are no longer triggered automatically.Learn more.

If the changes appear safe, you can manually trigger the pipeline by commenting/AzurePipelines run.

@anthonykim1anthonykim1 merged commit0317c6b intomicrosoft:mainMay 6, 2025
46 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@alexr00alexr00alexr00 approved these changes

Assignees

@anthonykim1anthonykim1

Labels
area-terminalbugIssue identified by VS Code Team member as probable bug
Projects
None yet
Milestone
May 2025
Development

Successfully merging this pull request may close these issues.

PYTHONSTARTUP is not injected when terminal env experiment is off
2 participants
@anthonykim1@alexr00
[8]ページ先頭
©2009-2025 Movatter.jp