Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: terminal error notification in untrusted workspace#24993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
karthiknadig merged 1 commit intomicrosoft:mainfromkarthiknadig:visible-tortoise
Apr 18, 2025

Conversation

karthiknadig
Copy link
Member

@karthiknadigkarthiknadig commentedApr 18, 2025•
edited
Loading

Fixes#24770

This call does not create a terminal in untrusted workspace. The call fails and creates a terminal failed notification. We should not be trying to create a terminal in untrusted workspace.

@karthiknadigkarthiknadig self-assigned thisApr 18, 2025
@karthiknadigkarthiknadig added bugIssue identified by VS Code Team member as probable bug skip testsUpdates to tests unnecessary labelsApr 18, 2025
@karthiknadigkarthiknadig marked this pull request as ready for reviewApril 18, 2025 18:21
@karthiknadigkarthiknadigenabled auto-merge (squash)April 18, 2025 18:21
@vs-code-engineeringvs-code-engineeringbot added this to theApril 2025 milestoneApr 18, 2025
@vs-code-engineeringVS Code Engineering
Copy link

⚠️ This PR originates from a fork. Due to security restrictions, pipelines from forks are no longer triggered automatically.Learn more.

If the changes appear safe, you can manually trigger the pipeline by commenting/AzurePipelines run.

@karthiknadigkarthiknadig merged commitcfc65ab intomicrosoft:mainApr 18, 2025
47 of 50 checks passed
@karthiknadigkarthiknadig deleted the visible-tortoise branchApril 18, 2025 20:02
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@meganroggemeganroggemeganrogge approved these changes

Assignees

@karthiknadigkarthiknadig

Labels
bugIssue identified by VS Code Team member as probable bugskip testsUpdates to tests unnecessary
Projects
None yet
Milestone
April 2025
Development

Successfully merging this pull request may close these issues.

Preventing Terminal Trust prompt
2 participants
@karthiknadig@meganrogge
[8]ページ先頭
©2009-2025 Movatter.jp