Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

remove ITestLogChannel#24954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
eleanorjboyd merged 4 commits intomicrosoft:mainfromeleanorjboyd:flat-tiger
Apr 2, 2025
Merged

Conversation

eleanorjboyd
Copy link
Member

No description provided.

@eleanorjboydeleanorjboyd added the debtCovers everything internal: CI, testing, refactoring of the codebase, etc. labelApr 1, 2025
@eleanorjboydeleanorjboyd self-assigned thisApr 1, 2025
@@ -79,7 +74,7 @@ export class UnittestTestDiscoveryAdapter implements ITestDiscoveryAdapter {
workspaceFolder: uri,
command,
cwd,
outChannel: this.outputChannel,
outChannel: this.logOutputChannel,
Copy link
MemberAuthor

@eleanorjboydeleanorjboydApr 1, 2025
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I have replacedITestOutputChannel withILogOutputChannel and still passing it through the the adapters to then add it to the spawn options here. Want to confirm this is necessary since I thought this output channel was used by spawn but not exactly sure how to confirm.@karthiknadig

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I think this looks fine. I am not really sure if this is even used internally anymore. But, need to follow the references here to understand better.

eleanorjboyd reacted with thumbs up emoji
Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

for recording purposes- Karthik and I looked into execObservable and found no usage of the output channel and so we it entirely from the adapter

@eleanorjboydeleanorjboyd marked this pull request as ready for reviewApril 1, 2025 21:12
@vs-code-engineeringVS Code Engineering
Copy link

⚠️ This PR originates from a fork. Due to security restrictions, pipelines from forks are no longer triggered automatically.Learn more.

If the changes appear safe, you can manually trigger the pipeline by commenting/AzurePipelines run.

@vs-code-engineeringvs-code-engineeringbot added this to theApril 2025 milestoneApr 1, 2025
@eleanorjboydeleanorjboyd merged commitcf91dc8 intomicrosoft:mainApr 2, 2025
46 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@anthonykim1anthonykim1anthonykim1 approved these changes

@karthiknadigkarthiknadigAwaiting requested review from karthiknadig

Assignees

@eleanorjboydeleanorjboyd

Labels
debtCovers everything internal: CI, testing, refactoring of the codebase, etc.skip-issue-check
Projects
None yet
Milestone
April 2025
Development

Successfully merging this pull request may close these issues.

3 participants
@eleanorjboyd@karthiknadig@anthonykim1

[8]ページ先頭

©2009-2025 Movatter.jp