Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

force absolute path for coverage results#24948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
eleanorjboyd merged 1 commit intomicrosoft:mainfromeleanorjboyd:watery-frog
Apr 2, 2025

Conversation

eleanorjboyd
Copy link
Member

fixes#24943

@eleanorjboydeleanorjboyd self-assigned thisMar 31, 2025
@eleanorjboydeleanorjboyd added the bugIssue identified by VS Code Team member as probable bug labelMar 31, 2025
@eleanorjboyd
Copy link
MemberAuthor

@karthiknadig or@anthonykim1 any thoughts on how I could test this? I can't seem to force it to use relative paths when I run coverage so I could mock out maybe "is_absolute" but that seems like it would be more work than use since it might just cause flakiness

@vs-code-engineeringVS Code Engineering
Copy link

⚠️ This PR originates from a fork. Due to security restrictions, pipelines from forks are no longer triggered automatically.Learn more.

If the changes appear safe, you can manually trigger the pipeline by commenting/AzurePipelines run.

@vs-code-engineeringvs-code-engineeringbot added this to theApril 2025 milestoneMar 31, 2025
@anthonykim1
Copy link

anthonykim1 commentedApr 2, 2025
edited
Loading

I would +1 on mocking "is_absolute"
I think@patch('pathlib.Path.is_absolute') is pretty much all you need assuming your tests will be on Python side.
Where patch is from unittest.mock.

@eleanorjboyd
Copy link
MemberAuthor

discussed with Karthik, effort not worth the minimal reward here so keeping it with the skip tests label

@eleanorjboydeleanorjboyd merged commitcd714bf intomicrosoft:mainApr 2, 2025
48 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@anthonykim1anthonykim1anthonykim1 approved these changes

@karthiknadigkarthiknadigAwaiting requested review from karthiknadig

Assignees

@eleanorjboydeleanorjboyd

Labels
bugIssue identified by VS Code Team member as probable bug
Projects
None yet
Milestone
April 2025
Development

Successfully merging this pull request may close these issues.

Can't open the original file for coverage view
2 participants
@eleanorjboyd@anthonykim1

[8]ページ先頭

©2009-2025 Movatter.jp