- Notifications
You must be signed in to change notification settings - Fork1.2k
force absolute path for coverage results#24948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
@karthiknadig or@anthonykim1 any thoughts on how I could test this? I can't seem to force it to use relative paths when I run coverage so I could mock out maybe "is_absolute" but that seems like it would be more work than use since it might just cause flakiness |
If the changes appear safe, you can manually trigger the pipeline by commenting |
anthonykim1 commentedApr 2, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
I would +1 on mocking "is_absolute" |
discussed with Karthik, effort not worth the minimal reward here so keeping it with the skip tests label |
cd714bf
intomicrosoft:mainUh oh!
There was an error while loading.Please reload this page.
fixes#24943