Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Always use environment path when running conda environment commands#24807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

jpcorreia99
Copy link

Attempt at fixing#24585

There are many edge scenarious where refering to the name of the environment rather than the path can cause breaks in the extension. Some examples

1 -If we have two anonymous environments with the same name in different folders

/path1/my-env
/path2/my-env (where my active vscode python interpreter is)
by using conda -n my-env it'll always use the first env.

2 -Some times people avoid actually activating their conda envs when using conda-packhttps://github.com/conda/conda-pack

This is because the activation scripts are known to be flaky and not very reliable

3 -The environment may have been created by a conda-compliant replacement

Therefore conda itself is not aware of it by name but can work with it properly using the path. This is the case ofhawk or frankly anyone building their own conda package manager on top ofrattler.

Some of these points are also hinted at#24627 (comment) , and supported by a conda maintainer in#24585 (comment)

This PR has a minimal attempt at changing that by always forcing -p usage

nilskch reacted with hooray emojinilskch reacted with rocket emoji
@jpcorreia99
Copy link
Author

@eleanorjboyd
@karthiknadig
@anthonykim1

While I work on getting the CLA approved, would really appreciate if someone could give this a look!

@karthiknadigkarthiknadig self-assigned thisFeb 11, 2025
@karthiknadigkarthiknadig added the bugIssue identified by VS Code Team member as probable bug labelFeb 11, 2025
karthiknadig
karthiknadig previously approved these changesFeb 11, 2025
@vs-code-engineeringvs-code-engineeringbot added this to theFebruary 2025 milestoneFeb 11, 2025
@karthiknadig
Copy link
Member

@jpcorreia99 This is a great idea to always use the prefix for therun scenario. We can give this a try and see if it work in all cases. From what I can tell it should.

jpcorreia99 reacted with heart emoji

@karthiknadigkarthiknadigenabled auto-merge (squash)February 11, 2025 15:29
auto-merge was automatically disabledFebruary 11, 2025 15:36

Head branch was pushed to by a user without write access

@jpcorreia99
Copy link
Author

jpcorreia99 commentedFeb 12, 2025
edited
Loading

hey@karthiknadig could you please reapprove the PR 🙏 Had to add an extra commit due to a unit test I had missed. CLA has been signed! (and you may want to remove the other reviewer if possible)

Also, is there documentation regarding the release cycle of the extension? Would be interested in knowing when I can expect this change to be available.

Thank you for the review!

@jpcorreia99
Copy link
Author

@microsoft-github-policy-service agree company="Palantir"

@jpcorreia99
Copy link
Author

@karthiknadig little ping here

@jpcorreia99
Copy link
Author

Hey@karthiknadig are the other two reviews still necessary? I just tagged the people who I've seen contributing the most recently to the extension

@karthiknadigkarthiknadig merged commit79e8a13 intomicrosoft:mainFeb 14, 2025
89 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@karthiknadigkarthiknadigkarthiknadig approved these changes

@eleanorjboydeleanorjboydeleanorjboyd approved these changes

@anthonykim1anthonykim1Awaiting requested review from anthonykim1

Assignees

@karthiknadigkarthiknadig

Labels
bugIssue identified by VS Code Team member as probable bug
Projects
None yet
Milestone
February 2025
Development

Successfully merging this pull request may close these issues.

3 participants
@jpcorreia99@karthiknadig@eleanorjboyd

[8]ページ先頭

©2009-2025 Movatter.jp