- Notifications
You must be signed in to change notification settings - Fork1.2k
Discovery cancellation#24713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Discovery cancellation#24713
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Copilot reviewed 5 out of 7 changed files in this pull request and generated 1 comment.
Files not reviewed (2)
- src/client/testing/testController/workspaceTestAdapter.ts: Evaluated as low risk
- src/client/testing/testController/pytest/pytestExecutionAdapter.ts: Evaluated as low risk
Comments suppressed due to low confidence (1)
src/client/testing/testController/pytest/pytestDiscoveryAdapter.ts:130
- Redundant cancellation handling. The
token?.onCancellationRequestedcallback is defined twice, once forprocand once forresultProc. This can be simplified to avoid confusion.
token?.onCancellationRequested(() => {Tip: Leave feedback on Copilot's review comments with the 👎 and 👍 buttons to help improve review quality.Learn more
src/client/testing/testController/unittest/testDiscoveryAdapter.ts OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
This PR originates from a fork. If the changes appear safe, you can trigger the pipeline by commenting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Copilot reviewed 5 out of 8 changed files in this pull request and generated no comments.
Files not reviewed (3)
- src/client/testing/testController/workspaceTestAdapter.ts: Evaluated as low risk
- src/client/testing/testController/pytest/pytestExecutionAdapter.ts: Evaluated as low risk
- src/client/testing/testController/unittest/testExecutionAdapter.ts: Evaluated as low risk
Comments suppressed due to low confidence (1)
src/client/testing/testController/pytest/pytestDiscoveryAdapter.ts:194
- The assignment of resultProc should be moved before the token cancellation check to avoid any potential race conditions.
const result = execService?.execObservable(execArgs, spawnOptions);Tip: Copilot only keeps its highest confidence comments to reduce noise and keep you focused.Learn more
8c54b8a intomicrosoft:mainUh oh!
There was an error while loading.Please reload this page.
fixes#24602