forked fromDonJayamanne/pythonVSCode
- Notifications
You must be signed in to change notification settings - Fork1.2k
remove commands for python.refreshTensorBoard and python.launchTensorBoard#24702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
@karthiknadig do you want these commands and all their references completely removed? |
also please confirm that this change should not cause a package-lock.json change. Thanks |
Yes and what you have is right. |
@DonJayamanne Adding you as reviewer since you removed these command registrations recently |
DonJayamanne approved these changesJan 8, 2025
2ebfae9 intomicrosoft:main 48 of 51 checks passed
Uh oh!
There was an error while loading.Please reload this page.
anthonykim1 pushed a commit to anthonykim1/vscode-python that referenced this pull requestJan 17, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
debtCovers everything internal: CI, testing, refactoring of the codebase, etc. skip package*.jsonpackage.json and package-lock.json don't both need updating skip-issue-check
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.