- Notifications
You must be signed in to change notification settings - Fork1.2k
Use env extension when available#24564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| hideFromUser: this.options?.hideFromUser, | ||
| }); | ||
| } else { | ||
| this.terminalShellType = this.terminalHelper.identifyTerminalShell(this.terminal); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
this isn't 100% accurate in terms of always getting the shell type right, correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
It is not, this is the same detector as the one Python extension uses. We need the shell type API to be more accurate.
| }); | ||
| this.terminalAutoActivator.disableAutoActivation(this.terminal); | ||
| await sleep(100); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
is there reason why we wait for short duration before activateEnvironmentInTerminal
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This is also from the existing activation. This is to give shell initialization enough time to start.
| if (pythonEnv && project) { | ||
| const fixedOptions = options ? { ...options } : { cwd: project.uri }; | ||
| const terminal = await api.createTerminal(pythonEnv, fixedOptions); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
it seems like this is calling createTerminal from env extension API, Im trying to understand why this and the interpreter one are both called "legacy"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Because it is temporary solution to the old features in the Python extension. These apis can be deleted when we delete the code for old Python features.
e789348 intomainUh oh!
There was an error while loading.Please reload this page.
No description provided.