forked fromDonJayamanne/pythonVSCode
- Notifications
You must be signed in to change notification settings - Fork1.2k
ruff 0.8.0 fixes#24488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
ruff 0.8.0 fixes#24488
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
visualstudio_py_testlauncher.py:133:24: UP031 Use format specifiers instead of percent format
karthiknadig approved these changesNov 25, 2024
lszomoru approved these changesNov 25, 2024
We typically keep python 3.8 support for 3 months after deprecation. Feb release is when we do official deprecation. Till then we would need to keep this from breaking. |
98fea6e intomicrosoft:main 42 of 48 checks passed
Uh oh!
There was an error while loading.Please reload this page.
@joar I am reverting this change since 3.8 broke with this change. I will restore it, after we deprecate 3.8 support in the extension (which will be in Feb 2025). |
karthiknadig added a commit that referenced this pull requestNov 25, 2024
This reverts commit98fea6e.
karthiknadig added a commit that referenced this pull requestNov 25, 2024
This reverts commit98fea6e.
karthiknadig added a commit that referenced this pull requestNov 25, 2024
karthiknadig pushed a commit that referenced this pull requestNov 26, 2024
`ruff` 0.8.0 (released 2024-11-22) no longer defaults to supportingPython 3.8,> Ruff now defaults to Python 3.9 instead of 3.8 if no explicit Pythonversion> is configured using[`ruff.target-version`](https://docs.astral.sh/ruff/settings/#target-version)> or[`project.requires-python`](https://packaging.python.org/en/latest/guides/writing-pyproject-toml/#python-requires)>([https://github.com/microsoft/vscode-python/pull/13896](https://github.com/astral-sh/ruff/pull/13896))> —https://github.com/astral-sh/ruff/blob/f3dac27e9aa6ac6a20fc2fb27ff2e4f5d369b076/CHANGELOG.md#080We want to support Python 3.8 until February 2025, so we need to set`target-version`.> The minimum Python version to target, e.g., when considering automaticcode> upgrades, like rewriting type annotations. Ruff will not proposechanges> using features that are not available in the given version.> —https://docs.astral.sh/ruff/settings/#target-versionCan be used as an alternative to#24488 until py38 supportis dropped.This PR also reverts the pinning of `ruff` merged in#24484.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ruff