forked fromDonJayamanne/pythonVSCode
- Notifications
You must be signed in to change notification settings - Fork1.2k
Improvement: Pass along python interpreter to jedi-language-server#22466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| @@ -76,6 +79,7 @@ export class JediLanguageServerAnalysisOptions extends LanguageServerAnalysisOpt | |||
| }, | |||
| workspace: { | |||
| extraPaths: distinctExtraPaths, | |||
| environmentPath: this.interpreter?.envPath, | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@karrtikr is this the right value to pass here ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Do you mean to pass the path to the environment folder here? For eg. this carries the path to.venv folder. If that's the case this looks good, but I'm not clear on what this is supposed to carry.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
It's indeed supposed to be the path to the environment. From briefly digging into the Jedi codebase, it seems to either expect the environment folder, or the bin/python executable within it.
@johnhany97 Can you sign the CLA? we can't merge this without it. |
karrtikr left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Please create an issue corresponding to this PR that you're attempting to solve.
| @@ -76,6 +79,7 @@ export class JediLanguageServerAnalysisOptions extends LanguageServerAnalysisOpt | |||
| }, | |||
| workspace: { | |||
| extraPaths: distinctExtraPaths, | |||
| environmentPath: this.interpreter?.envPath, | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Do you mean to pass the path to the environment folder here? For eg. this carries the path to.venv folder. If that's the case this looks good, but I'm not clear on what this is supposed to carry.
Uh oh!
There was an error while loading.Please reload this page.
I'll make sure to create an issue detailing the issue I saw tomorrow morning, and will sign the CLA once my company confirms I'm allowed to sign (should know by EOW). I appreciate the speedy review, and will revert back shortly. |
@microsoft-github-policy-service agree |
karrtikr approved these changesNov 27, 2023
karrtikr left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM if we are able to verify the fix works, i.e Jedi continues to work for global interpreters and environments and when switching between them.
karthiknadig approved these changesNov 28, 2023
wesm pushed a commit to posit-dev/positron that referenced this pull requestMar 28, 2024
…from upstreamMerge pull request#277 from posit-dev/merge/2023.22Merge vscode-python 2023.22 from upstream--------------------Commit message forposit-dev/positron-python@2e3ea32:handle new upstream `deprecated` response upon parser error--------------------Commit message forposit-dev/positron-python@d50c326:Update yarn.lock--------------------Commit message forposit-dev/positron-python@105bf9d:Merge commit 'a0cddbdf0939729cdb82dca2d129433ad475f51e'--------------------Commit message formicrosoft/vscode-python@a0cddbd:bump-release-2023.22 (microsoft/vscode-python#22587)bump to release version 2023.22 and update package.json--------------------Commit message formicrosoft/vscode-python@5302d0e:Revert unsuccessful REPL decoration fix and disable for windows (microsoft/vscode-python#22578)Revertingmicrosoft/vscode-python#22572 since it is producing color decoration on weird PythonREPL spot for Windows pwsh users, and disable decoration entirely forWindows pwsh users temporarily while trying to fix specific problem.Disable feature for stable. Refer:microsoft/vscode-python#22546microsoft/vscode-python#22535--------------------Commit message formicrosoft/vscode-python@bffc9b3:Fix shell integration decoration bug for Windows pwsh (microsoft/vscode-python#22572)Attempt to fix colorless and randomized circle decoration for PythonREPL usage by Windows Powershell users.Resolves:microsoft/vscode-python#22546microsoft/vscode-python#22535--------------------Commit message formicrosoft/vscode-python@e1b54d0:fix no test id provided for pytest run (microsoft/vscode-python#22569)fixesmicrosoft/vscode-python#22567Now if a user tries to click the "run" button a empty folder (ie afolder with no tests in it) it will just run pytest with no testIds asargs and notify the user.--------------------Commit message formicrosoft/vscode-python@61fcf3a:Properly build deactivate commands for powershell (microsoft/vscode-python#22570)Formicrosoft/vscode-python#20950--------------------Commit message formicrosoft/vscode-python@db6e15e:Do not throw if initializing deactivate script fails (microsoft/vscode-python#22566)Formicrosoft/vscode-python#20950--------------------Commit message formicrosoft/vscode-python@caa50dc:Fix shell integration decoration for windows pwsh (microsoft/vscode-python#22560)Attempting to fix shell integration decoration glitch for windows pwshwhen using Python REPL from VS Code.Resolves:microsoft/vscode-python#22546microsoft/vscode-python#22535--------------------Commit message formicrosoft/vscode-python@3efb54f:White space after REPL prompt (microsoft/vscode-python#22549)There should be white space after new REPL prompt that I override forpurpose of shell integration.Resolves:microsoft/vscode-python#22548--------------------Commit message formicrosoft/vscode-python@261ae66:Improvement: Pass along python interpreter to jedi-language-server (microsoft/vscode-python#22466)Fixesmicrosoft/vscode-python#22495## Before this PROverriding the Python interpreter to a different environment that isn'tthe current globally-activated base environment would yield nocompletions when Jedi is used as the underlying language server.Example [stackoverflowquestion](https://stackoverflow.com/questions/62018436/vscode-intellisense-code-completion-doesnt-work-when-i-am-not-in-base-conda-e)hitting the same issue.## After this PRWe now pass along the interpreter path to jedi-language-server as partof the initial options under `workspace.environmentPath`([ref](https://github.com/pappasam/jedi-language-server/#workspaceenvironmentpath))--------------------Commit message formicrosoft/vscode-python@1639753:switch to conditional error message on check for UUID and port during pytest config (microsoft/vscode-python#22534)fixesmicrosoft/vscode-python#19857--------------------Commit message formicrosoft/vscode-python@9a5363c:Resolve test suite discovery import errors due to path ordering (microsoft/vscode-python#22454)[Issuemicrosoft/vscode-python#22453](microsoft/vscode-python#22453)- Once starting to run discovery, add the projects root path to PATH atindex 0 so that any further imports will use the projects root directoryand not reference the incorrect directory.- Since the test suite only allows the start_dir to be one directorydeep, we can conclude that if the start_dir is not "." or contains a"/", that we need to add that start_dir's parent to PATH. Otherwise, wesimply add the start_dir to PATH.--------------------Commit message formicrosoft/vscode-python@eb96141:Use shell integration to denote success/failure (microsoft/vscode-python#22487)Resolves:microsoft/vscode-python#22486Use shell integration to denote success/failure in Python REPL launchedfrom VS Code.This would mean having the blue or red decorators based on whether ornot user's command succeeded.--------------------Commit message formicrosoft/vscode-python@f6e1338:Use worker threads for fetching conda environments and interpreter related info (microsoft/vscode-python#22481)--------------------Commit message formicrosoft/vscode-python@3c552f9:Show warning and allow user to turn off smart send for deprecated Python code (microsoft/vscode-python#22353)Resolves:microsoft/vscode-python#22341microsoft/vscode-python#22340Showing warning message after detecting user is on Python file withdeprecated Python code, and are attempting to run smart send viashift+enter action. Allow user to turn off this via workspace setting.---------Co-authored-by: Courtney Webster <60238438+cwebster-99@users.noreply.github.com>Co-authored-by: Kartik Raj <karraj@microsoft.com>--------------------Commit message formicrosoft/vscode-python@ef983f4:Bump `vscode-tas-client` and fix tests (microsoft/vscode-python#22493)Closesmicrosoft/vscode-python#22461Sinon requires the actual object definition, so we need to point it tothe module file that actually has the function.--------------------Commit message formicrosoft/vscode-python@9298b2c:Bump dessant/lock-threads from 4 to 5 (microsoft/vscode-python#22474)Bumps [dessant/lock-threads](https://github.com/dessant/lock-threads)from 4 to 5.<details><summary>Release notes</summary><p><em>Sourced from <ahref="https://github.com/dessant/lock-threads/releases">dessant/lock-threads'sreleases</a>.</em></p><blockquote><h2>v5.0.0</h2><p>Learn more about this release from the <ahref="https://github.com/dessant/lock-threads/blob/main/CHANGELOG.md#changelog">changelog</a>.</p><h2>v4.0.1</h2><p>Learn more about this release from the <ahref="https://github.com/dessant/lock-threads/blob/main/CHANGELOG.md#changelog">changelog</a>.</p></blockquote></details><details><summary>Changelog</summary><p><em>Sourced from <ahref="https://github.com/dessant/lock-threads/blob/main/CHANGELOG.md">dessant/lock-threads'schangelog</a>.</em></p><blockquote><h2><ahref="https://github.com/dessant/lock-threads/compare/v4.0.1...v5.0.0">5.0.0</a>(2023-11-14)</h2><h3>⚠ BREAKING CHANGES</h3><ul><li>Discussions are also processed by default,set the <code>process-only</code> input parameter to preserve the oldbehavior</li></ul><pre lang="yaml"><code> steps: - uses: dessant/lock-threads@v5 with: process-only: 'issues, prs'</code></pre><ul><li>the action now requires Node.js 20</li></ul><h3>Features</h3><ul><li>lock discussions (<ahref="https://github.com/dessant/lock-threads/commit/0a0976f3ded51c88c6128dd96dd115c9f14fa764">0a0976f</a>),closes <ahref="https://redirect.github.com/dessant/lock-threads/issues/25">#25</a></li></ul><h3>Bug Fixes</h3><ul><li>update dependencies (<ahref="https://github.com/dessant/lock-threads/commit/5a25b54eae3e7a5580d09ef0f7cbc5b18376db67">5a25b54</a>)</li></ul><h3><ahref="https://github.com/dessant/lock-threads/compare/v4.0.0...v4.0.1">4.0.1</a>(2023-06-12)</h3><h3>Bug Fixes</h3><ul><li>retry and throttle GitHub API requests (<ahref="https://github.com/dessant/lock-threads/commit/1618e91da69b9fe614fb9837ac673ea4600eb529">1618e91</a>),closes <ahref="https://redirect.github.com/dessant/lock-threads/issues/35">#35</a></li></ul><h2><ahref="https://github.com/dessant/lock-threads/compare/v3.0.0...v4.0.0">4.0.0</a>(2022-12-04)</h2><h3>⚠ BREAKING CHANGES</h3><ul><li>the action now requires Node.js 16</li></ul><h3>Bug Fixes</h3><ul><li>update dependencies (<ahref="https://github.com/dessant/lock-threads/commit/38e918558115222435d26c0639870cdbe3572929">38e9185</a>)</li><li>update docs (<ahref="https://github.com/dessant/lock-threads/commit/32986e26965060a85db09e98ef7e5958c961ae84">32986e2</a>)</li></ul><h2><ahref="https://github.com/dessant/lock-threads/compare/v2.1.2...v3.0.0">3.0.0</a>(2021-09-27)</h2><h3>⚠ BREAKING CHANGES</h3><ul><li>input parameter names have changed</li></ul><!-- raw HTML omitted --></blockquote><p>... (truncated)</p></details><details><summary>Commits</summary><ul><li><ahref="https://github.com/dessant/lock-threads/commit/d42e5f49803f3c4e14ffee0378e31481265dda22"><code>d42e5f4</code></a>chore(release): 5.0.0</li><li><ahref="https://github.com/dessant/lock-threads/commit/d8da6c1485cbe748b5b632f1a52cf2a52941cbf9"><code>d8da6c1</code></a>chore: update package</li><li><ahref="https://github.com/dessant/lock-threads/commit/c1eab4b45f97073a922fbd226afab0e34a70cf5f"><code>c1eab4b</code></a>chore: update workflow</li><li><ahref="https://github.com/dessant/lock-threads/commit/0a0976f3ded51c88c6128dd96dd115c9f14fa764"><code>0a0976f</code></a>feat: lock discussions</li><li><ahref="https://github.com/dessant/lock-threads/commit/53f3f0c0b9158bece84746885adc5f4bf2dd1ddc"><code>53f3f0c</code></a>chore: migrate package to ESM</li><li><ahref="https://github.com/dessant/lock-threads/commit/5a25b54eae3e7a5580d09ef0f7cbc5b18376db67"><code>5a25b54</code></a>fix: update dependencies</li><li>See full diff in <ahref="https://github.com/dessant/lock-threads/compare/v4...v5">compareview</a></li></ul></details><br />[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)Dependabot will resolve any conflicts with this PR as long as you don'talter it yourself. You can also trigger a rebase manually by commenting`@dependabot rebase`.[//]: # (dependabot-automerge-start)[//]: # (dependabot-automerge-end)---<details><summary>Dependabot commands and options</summary><br />You can trigger Dependabot actions by commenting on this PR:- `@dependabot rebase` will rebase this PR- `@dependabot recreate` will recreate this PR, overwriting any editsthat have been made to it- `@dependabot merge` will merge this PR after your CI passes on it- `@dependabot squash and merge` will squash and merge this PR afteryour CI passes on it- `@dependabot cancel merge` will cancel a previously requested mergeand block automerging- `@dependabot reopen` will reopen this PR if it is closed- `@dependabot close` will close this PR and stop Dependabot recreatingit. You can achieve the same result by closing it manually- `@dependabot show <dependency name> ignore conditions` will show allof the ignore conditions of the specified dependency- `@dependabot ignore this major version` will close this PR and stopDependabot creating any more for this major version (unless you reopenthe PR or upgrade to it yourself)- `@dependabot ignore this minor version` will close this PR and stopDependabot creating any more for this minor version (unless you reopenthe PR or upgrade to it yourself)- `@dependabot ignore this dependency` will close this PR and stopDependabot creating any more for this dependency (unless you reopen thePR or upgrade to it yourself)</details>Signed-off-by: dependabot[bot] <support@github.com>Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>--------------------Commit message formicrosoft/vscode-python@e27185a:Use worker threads for fetching Windows Registry interpreters (microsoft/vscode-python#22479)Formicrosoft/vscode-python#22146--------------------Commit message formicrosoft/vscode-python@7a4de92:Use `WorkspaceFolder.name` in addition to workspace folder's basename when resolving `${workspaceFolder:name}` syntax in settings (microsoft/vscode-python#22471)Closesmicrosoft/vscode-python#22452--------------------Commit message formicrosoft/vscode-python@fbfa126:Add 3.12 to conda version list (microsoft/vscode-python#22470)--------------------Commit message formicrosoft/vscode-python@47552a3:Install requirements before toml (microsoft/vscode-python#22468)Fixesmicrosoft/vscode-python#22423--------------------Commit message formicrosoft/vscode-python@a1fac81:If active editor opened is outside the editor, activate the first workspace (microsoft/vscode-python#22450)Formicrosoft/vscode-python#22449--------------------Commit message formicrosoft/vscode-python@b68ddee:Support deactivating virtual environments without user intervention (microsoft/vscode-python#22405)Closesmicrosoft/vscode-python#22448Adds deactivate script to `PATH`--------------------Commit message formicrosoft/vscode-python@8d174a8:Fix shell integration API reliability (microsoft/vscode-python#22446)microsoft/vscode-python#22440It leads to terminals activating forever.--------------------Commit message formicrosoft/vscode-python@1b3c1ea:Adding `Locked` comments to walkthrough commands (microsoft/vscode-python#22432)Adds comments to lock command names for walkthrough localization. Onlyadded Locked comments for walkthrough tiles that are in use and havecommands--------------------Commit message formicrosoft/vscode-python@2fc9fea:Revert "Reliably detect whether shell integration is working" (microsoft/vscode-python#22445)Revertsmicrosoft/vscode-python#22440It seems reactivating never finishes after this, although this doesn'trepro when debugging the extension, have to investigate further.--------------------Commit message formicrosoft/vscode-python@f98caf6:Add consoleTitle to launch.json properties schema (microsoft/vscode-python#22406)consoleTitle is effectively an undocumented feature. pydebug accepts theconfig key, but vscode will report a problem because it is missing fromthe schema. see [this debugpyissue](microsoft/debugpy#1178) and[#13040](microsoft/vscode-python#13040)I used the phrase "console or terminal" because I noticed the name wasrepresented on both integratedTerminal and internalConsole. I didn'ttest externalTerminal.---------Co-authored-by: Luciana Abud <45497113+luabud@users.noreply.github.com>--------------------Commit message formicrosoft/vscode-python@2a976e3:Reliably detect whether shell integration is working (microsoft/vscode-python#22440)Closesmicrosoft/vscode-python#22439Blocked onhttps://github.com/microsoft/vscode-distro/pull/822--------------------Commit message formicrosoft/vscode-python@67b4801:Improve shell identifier on case-insensitive system (microsoft/vscode-python#22391)Use case-insensitive regex to remove `.exe` extension.See:microsoft/vscode-python#22036 (comment)--------------------Commit message formicrosoft/vscode-python@7bc45e5:Do not attempt to kill the process if it has already exited (microsoft/vscode-python#22424)Closesmicrosoft/vscode-python#22420This bugs seems to have existed every since `rawProcessApi.ts` wascreated. `proc.killed` can be `false` even after process has exited.--------------------Commit message formicrosoft/vscode-python@f6cfa6e:Remove old code for folder support in interpreter path setting (microsoft/vscode-python#22413)Closesmicrosoft/vscode-python#12452Lead-authored-by: Kartik Raj <karraj@microsoft.com>Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>Co-authored-by: Courtney Webster <60238438+cwebster-99@users.noreply.github.com>Co-authored-by: John H. Ayad <johnhany97@gmail.com>Co-authored-by: Wasim Lorgat <mwlorgat@gmail.com>Co-authored-by: Shane Saravia <shanesaravia@live.ca>Co-authored-by: Trysten <trysten@sleepyowl.com>Co-authored-by: JamzumSum <zzzzss990315@gmail.com>Co-authored-by: Eleanor Boyd <eleanorboyd@microsoft.com>Co-authored-by: Karthik Nadig <kanadig@microsoft.com>Co-authored-by: Pete Farland <pete.farland@posit.co>Co-authored-by: Anthony Kim <62267334+anthonykim1@users.noreply.github.com>Signed-off-by: GitHub <noreply@github.com>
wesm pushed a commit to posit-dev/positron that referenced this pull requestMar 28, 2024
…from upstreamMerge pull request#277 from posit-dev/merge/2023.22Merge vscode-python 2023.22 from upstream--------------------Commit message forposit-dev/positron-python@2e3ea32:handle new upstream `deprecated` response upon parser error--------------------Commit message forposit-dev/positron-python@d50c326:Update yarn.lock--------------------Commit message forposit-dev/positron-python@105bf9d:Merge commit 'a0cddbdf0939729cdb82dca2d129433ad475f51e'--------------------Commit message formicrosoft/vscode-python@a0cddbd:bump-release-2023.22 (microsoft/vscode-python#22587)bump to release version 2023.22 and update package.json--------------------Commit message formicrosoft/vscode-python@5302d0e:Revert unsuccessful REPL decoration fix and disable for windows (microsoft/vscode-python#22578)Revertingmicrosoft/vscode-python#22572 since it is producing color decoration on weird PythonREPL spot for Windows pwsh users, and disable decoration entirely forWindows pwsh users temporarily while trying to fix specific problem.Disable feature for stable. Refer:microsoft/vscode-python#22546microsoft/vscode-python#22535--------------------Commit message formicrosoft/vscode-python@bffc9b3:Fix shell integration decoration bug for Windows pwsh (microsoft/vscode-python#22572)Attempt to fix colorless and randomized circle decoration for PythonREPL usage by Windows Powershell users.Resolves:microsoft/vscode-python#22546microsoft/vscode-python#22535--------------------Commit message formicrosoft/vscode-python@e1b54d0:fix no test id provided for pytest run (microsoft/vscode-python#22569)fixesmicrosoft/vscode-python#22567Now if a user tries to click the "run" button a empty folder (ie afolder with no tests in it) it will just run pytest with no testIds asargs and notify the user.--------------------Commit message formicrosoft/vscode-python@61fcf3a:Properly build deactivate commands for powershell (microsoft/vscode-python#22570)Formicrosoft/vscode-python#20950--------------------Commit message formicrosoft/vscode-python@db6e15e:Do not throw if initializing deactivate script fails (microsoft/vscode-python#22566)Formicrosoft/vscode-python#20950--------------------Commit message formicrosoft/vscode-python@caa50dc:Fix shell integration decoration for windows pwsh (microsoft/vscode-python#22560)Attempting to fix shell integration decoration glitch for windows pwshwhen using Python REPL from VS Code.Resolves:microsoft/vscode-python#22546microsoft/vscode-python#22535--------------------Commit message formicrosoft/vscode-python@3efb54f:White space after REPL prompt (microsoft/vscode-python#22549)There should be white space after new REPL prompt that I override forpurpose of shell integration.Resolves:microsoft/vscode-python#22548--------------------Commit message formicrosoft/vscode-python@261ae66:Improvement: Pass along python interpreter to jedi-language-server (microsoft/vscode-python#22466)Fixesmicrosoft/vscode-python#22495## Before this PROverriding the Python interpreter to a different environment that isn'tthe current globally-activated base environment would yield nocompletions when Jedi is used as the underlying language server.Example [stackoverflowquestion](https://stackoverflow.com/questions/62018436/vscode-intellisense-code-completion-doesnt-work-when-i-am-not-in-base-conda-e)hitting the same issue.## After this PRWe now pass along the interpreter path to jedi-language-server as partof the initial options under `workspace.environmentPath`([ref](https://github.com/pappasam/jedi-language-server/#workspaceenvironmentpath))--------------------Commit message formicrosoft/vscode-python@1639753:switch to conditional error message on check for UUID and port during pytest config (microsoft/vscode-python#22534)fixesmicrosoft/vscode-python#19857--------------------Commit message formicrosoft/vscode-python@9a5363c:Resolve test suite discovery import errors due to path ordering (microsoft/vscode-python#22454)[Issuemicrosoft/vscode-python#22453](microsoft/vscode-python#22453)- Once starting to run discovery, add the projects root path to PATH atindex 0 so that any further imports will use the projects root directoryand not reference the incorrect directory.- Since the test suite only allows the start_dir to be one directorydeep, we can conclude that if the start_dir is not "." or contains a"/", that we need to add that start_dir's parent to PATH. Otherwise, wesimply add the start_dir to PATH.--------------------Commit message formicrosoft/vscode-python@eb96141:Use shell integration to denote success/failure (microsoft/vscode-python#22487)Resolves:microsoft/vscode-python#22486Use shell integration to denote success/failure in Python REPL launchedfrom VS Code.This would mean having the blue or red decorators based on whether ornot user's command succeeded.--------------------Commit message formicrosoft/vscode-python@f6e1338:Use worker threads for fetching conda environments and interpreter related info (microsoft/vscode-python#22481)--------------------Commit message formicrosoft/vscode-python@3c552f9:Show warning and allow user to turn off smart send for deprecated Python code (microsoft/vscode-python#22353)Resolves:microsoft/vscode-python#22341microsoft/vscode-python#22340Showing warning message after detecting user is on Python file withdeprecated Python code, and are attempting to run smart send viashift+enter action. Allow user to turn off this via workspace setting.---------Co-authored-by: Courtney Webster <60238438+cwebster-99@users.noreply.github.com>Co-authored-by: Kartik Raj <karraj@microsoft.com>--------------------Commit message formicrosoft/vscode-python@ef983f4:Bump `vscode-tas-client` and fix tests (microsoft/vscode-python#22493)Closesmicrosoft/vscode-python#22461Sinon requires the actual object definition, so we need to point it tothe module file that actually has the function.--------------------Commit message formicrosoft/vscode-python@9298b2c:Bump dessant/lock-threads from 4 to 5 (microsoft/vscode-python#22474)Bumps [dessant/lock-threads](https://github.com/dessant/lock-threads)from 4 to 5.<details><summary>Release notes</summary><p><em>Sourced from <ahref="https://github.com/dessant/lock-threads/releases">dessant/lock-threads'sreleases</a>.</em></p><blockquote><h2>v5.0.0</h2><p>Learn more about this release from the <ahref="https://github.com/dessant/lock-threads/blob/main/CHANGELOG.md#changelog">changelog</a>.</p><h2>v4.0.1</h2><p>Learn more about this release from the <ahref="https://github.com/dessant/lock-threads/blob/main/CHANGELOG.md#changelog">changelog</a>.</p></blockquote></details><details><summary>Changelog</summary><p><em>Sourced from <ahref="https://github.com/dessant/lock-threads/blob/main/CHANGELOG.md">dessant/lock-threads'schangelog</a>.</em></p><blockquote><h2><ahref="https://github.com/dessant/lock-threads/compare/v4.0.1...v5.0.0">5.0.0</a>(2023-11-14)</h2><h3>⚠ BREAKING CHANGES</h3><ul><li>Discussions are also processed by default,set the <code>process-only</code> input parameter to preserve the oldbehavior</li></ul><pre lang="yaml"><code> steps: - uses: dessant/lock-threads@v5 with: process-only: 'issues, prs'</code></pre><ul><li>the action now requires Node.js 20</li></ul><h3>Features</h3><ul><li>lock discussions (<ahref="https://github.com/dessant/lock-threads/commit/0a0976f3ded51c88c6128dd96dd115c9f14fa764">0a0976f</a>),closes <ahref="https://redirect.github.com/dessant/lock-threads/issues/25">#25</a></li></ul><h3>Bug Fixes</h3><ul><li>update dependencies (<ahref="https://github.com/dessant/lock-threads/commit/5a25b54eae3e7a5580d09ef0f7cbc5b18376db67">5a25b54</a>)</li></ul><h3><ahref="https://github.com/dessant/lock-threads/compare/v4.0.0...v4.0.1">4.0.1</a>(2023-06-12)</h3><h3>Bug Fixes</h3><ul><li>retry and throttle GitHub API requests (<ahref="https://github.com/dessant/lock-threads/commit/1618e91da69b9fe614fb9837ac673ea4600eb529">1618e91</a>),closes <ahref="https://redirect.github.com/dessant/lock-threads/issues/35">#35</a></li></ul><h2><ahref="https://github.com/dessant/lock-threads/compare/v3.0.0...v4.0.0">4.0.0</a>(2022-12-04)</h2><h3>⚠ BREAKING CHANGES</h3><ul><li>the action now requires Node.js 16</li></ul><h3>Bug Fixes</h3><ul><li>update dependencies (<ahref="https://github.com/dessant/lock-threads/commit/38e918558115222435d26c0639870cdbe3572929">38e9185</a>)</li><li>update docs (<ahref="https://github.com/dessant/lock-threads/commit/32986e26965060a85db09e98ef7e5958c961ae84">32986e2</a>)</li></ul><h2><ahref="https://github.com/dessant/lock-threads/compare/v2.1.2...v3.0.0">3.0.0</a>(2021-09-27)</h2><h3>⚠ BREAKING CHANGES</h3><ul><li>input parameter names have changed</li></ul><!-- raw HTML omitted --></blockquote><p>... (truncated)</p></details><details><summary>Commits</summary><ul><li><ahref="https://github.com/dessant/lock-threads/commit/d42e5f49803f3c4e14ffee0378e31481265dda22"><code>d42e5f4</code></a>chore(release): 5.0.0</li><li><ahref="https://github.com/dessant/lock-threads/commit/d8da6c1485cbe748b5b632f1a52cf2a52941cbf9"><code>d8da6c1</code></a>chore: update package</li><li><ahref="https://github.com/dessant/lock-threads/commit/c1eab4b45f97073a922fbd226afab0e34a70cf5f"><code>c1eab4b</code></a>chore: update workflow</li><li><ahref="https://github.com/dessant/lock-threads/commit/0a0976f3ded51c88c6128dd96dd115c9f14fa764"><code>0a0976f</code></a>feat: lock discussions</li><li><ahref="https://github.com/dessant/lock-threads/commit/53f3f0c0b9158bece84746885adc5f4bf2dd1ddc"><code>53f3f0c</code></a>chore: migrate package to ESM</li><li><ahref="https://github.com/dessant/lock-threads/commit/5a25b54eae3e7a5580d09ef0f7cbc5b18376db67"><code>5a25b54</code></a>fix: update dependencies</li><li>See full diff in <ahref="https://github.com/dessant/lock-threads/compare/v4...v5">compareview</a></li></ul></details><br />[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)Dependabot will resolve any conflicts with this PR as long as you don'talter it yourself. You can also trigger a rebase manually by commenting`@dependabot rebase`.[//]: # (dependabot-automerge-start)[//]: # (dependabot-automerge-end)---<details><summary>Dependabot commands and options</summary><br />You can trigger Dependabot actions by commenting on this PR:- `@dependabot rebase` will rebase this PR- `@dependabot recreate` will recreate this PR, overwriting any editsthat have been made to it- `@dependabot merge` will merge this PR after your CI passes on it- `@dependabot squash and merge` will squash and merge this PR afteryour CI passes on it- `@dependabot cancel merge` will cancel a previously requested mergeand block automerging- `@dependabot reopen` will reopen this PR if it is closed- `@dependabot close` will close this PR and stop Dependabot recreatingit. You can achieve the same result by closing it manually- `@dependabot show <dependency name> ignore conditions` will show allof the ignore conditions of the specified dependency- `@dependabot ignore this major version` will close this PR and stopDependabot creating any more for this major version (unless you reopenthe PR or upgrade to it yourself)- `@dependabot ignore this minor version` will close this PR and stopDependabot creating any more for this minor version (unless you reopenthe PR or upgrade to it yourself)- `@dependabot ignore this dependency` will close this PR and stopDependabot creating any more for this dependency (unless you reopen thePR or upgrade to it yourself)</details>Signed-off-by: dependabot[bot] <support@github.com>Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>--------------------Commit message formicrosoft/vscode-python@e27185a:Use worker threads for fetching Windows Registry interpreters (microsoft/vscode-python#22479)Formicrosoft/vscode-python#22146--------------------Commit message formicrosoft/vscode-python@7a4de92:Use `WorkspaceFolder.name` in addition to workspace folder's basename when resolving `${workspaceFolder:name}` syntax in settings (microsoft/vscode-python#22471)Closesmicrosoft/vscode-python#22452--------------------Commit message formicrosoft/vscode-python@fbfa126:Add 3.12 to conda version list (microsoft/vscode-python#22470)--------------------Commit message formicrosoft/vscode-python@47552a3:Install requirements before toml (microsoft/vscode-python#22468)Fixesmicrosoft/vscode-python#22423--------------------Commit message formicrosoft/vscode-python@a1fac81:If active editor opened is outside the editor, activate the first workspace (microsoft/vscode-python#22450)Formicrosoft/vscode-python#22449--------------------Commit message formicrosoft/vscode-python@b68ddee:Support deactivating virtual environments without user intervention (microsoft/vscode-python#22405)Closesmicrosoft/vscode-python#22448Adds deactivate script to `PATH`--------------------Commit message formicrosoft/vscode-python@8d174a8:Fix shell integration API reliability (microsoft/vscode-python#22446)microsoft/vscode-python#22440It leads to terminals activating forever.--------------------Commit message formicrosoft/vscode-python@1b3c1ea:Adding `Locked` comments to walkthrough commands (microsoft/vscode-python#22432)Adds comments to lock command names for walkthrough localization. Onlyadded Locked comments for walkthrough tiles that are in use and havecommands--------------------Commit message formicrosoft/vscode-python@2fc9fea:Revert "Reliably detect whether shell integration is working" (microsoft/vscode-python#22445)Revertsmicrosoft/vscode-python#22440It seems reactivating never finishes after this, although this doesn'trepro when debugging the extension, have to investigate further.--------------------Commit message formicrosoft/vscode-python@f98caf6:Add consoleTitle to launch.json properties schema (microsoft/vscode-python#22406)consoleTitle is effectively an undocumented feature. pydebug accepts theconfig key, but vscode will report a problem because it is missing fromthe schema. see [this debugpyissue](microsoft/debugpy#1178) and[#13040](microsoft/vscode-python#13040)I used the phrase "console or terminal" because I noticed the name wasrepresented on both integratedTerminal and internalConsole. I didn'ttest externalTerminal.---------Co-authored-by: Luciana Abud <45497113+luabud@users.noreply.github.com>--------------------Commit message formicrosoft/vscode-python@2a976e3:Reliably detect whether shell integration is working (microsoft/vscode-python#22440)Closesmicrosoft/vscode-python#22439Blocked onhttps://github.com/microsoft/vscode-distro/pull/822--------------------Commit message formicrosoft/vscode-python@67b4801:Improve shell identifier on case-insensitive system (microsoft/vscode-python#22391)Use case-insensitive regex to remove `.exe` extension.See:microsoft/vscode-python#22036 (comment)--------------------Commit message formicrosoft/vscode-python@7bc45e5:Do not attempt to kill the process if it has already exited (microsoft/vscode-python#22424)Closesmicrosoft/vscode-python#22420This bugs seems to have existed every since `rawProcessApi.ts` wascreated. `proc.killed` can be `false` even after process has exited.--------------------Commit message formicrosoft/vscode-python@f6cfa6e:Remove old code for folder support in interpreter path setting (microsoft/vscode-python#22413)Closesmicrosoft/vscode-python#12452Lead-authored-by: Kartik Raj <karraj@microsoft.com>Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>Co-authored-by: Courtney Webster <60238438+cwebster-99@users.noreply.github.com>Co-authored-by: John H. Ayad <johnhany97@gmail.com>Co-authored-by: Wasim Lorgat <mwlorgat@gmail.com>Co-authored-by: Shane Saravia <shanesaravia@live.ca>Co-authored-by: Trysten <trysten@sleepyowl.com>Co-authored-by: JamzumSum <zzzzss990315@gmail.com>Co-authored-by: Eleanor Boyd <eleanorboyd@microsoft.com>Co-authored-by: Karthik Nadig <kanadig@microsoft.com>Co-authored-by: Pete Farland <pete.farland@posit.co>Co-authored-by: Anthony Kim <62267334+anthonykim1@users.noreply.github.com>Signed-off-by: GitHub <noreply@github.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Fixes#22495
Before this PR
Overriding the Python interpreter to a different environment that isn't the current globally-activated base environment would yield no completions when Jedi is used as the underlying language server.
Examplestackoverflow question hitting the same issue.
After this PR
We now pass along the interpreter path to jedi-language-server as part of the initial options under
workspace.environmentPath(ref)