- Notifications
You must be signed in to change notification settings - Fork1.2k
Updates to envvars for CI build to support VSTS automation#1872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Spawn a new build... |
codecovbot commentedJun 5, 2018 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report
@@ Coverage Diff @@## master #1872 +/- ##==========================================+ Coverage 74.44% 74.46% +0.02%========================================== Files 282 282 Lines 13253 13253 Branches 2382 2382 ==========================================+ Hits 9866 9869 +3+ Misses 3257 3253 -4- Partials 130 131 +1
Continue to review full report at Codecov.
|
Try this out on the new CI definition in VSTS... |
Another crack at VSTS CI |
Once again... |
Once again... |
@DonJayamanne this change actually doesn't seem to have any effect at all. If you look here at the code, and then search the 'testSingleWorkspace' output for that test, you can see the |
DonJayamanne commentedJun 7, 2018 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Agreed, something wrong in VSTS, cuz it works as expected on Travis and appveyor |
- case insensitive value was failing my use case- VSTS tooling only tests this way too
I found it. The VSTS env var My expression was failing due to case mismatch! I found that in the VSTS tooling it is enough to test for theexistance of the |
@DonJayamanne yep this fixes it! I'm shoving it in... will watch it and revert tonight if it turns out problematic... |
Extend const
IS_CI_SERVER
fromsrc/test/constants.ts
to include new constantIS_VSTS
, represented by the environment variableTF_BUILD
present on VSTS.MochaOpts.useColor=false
to take into account VSTS's lack of support for this.Helps#934
This pull request: