Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Updates to envvars for CI build to support VSTS automation#1872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
d3r3kk merged 2 commits intomicrosoft:masterfromd3r3kk:tf_ci
Jun 7, 2018

Conversation

d3r3kk
Copy link

Extend constIS_CI_SERVER fromsrc/test/constants.ts to include new constantIS_VSTS, represented by the environment variableTF_BUILD present on VSTS.

  • SetMochaOpts.useColor=false to take into account VSTS's lack of support for this.

Helps#934

This pull request:

  • Has a title summarizes what is changing
  • Includes anews entry file (remember to thank yourself!)
  • Works on allactively maintained versions of Python (e.g. Python 2.7 & the latest Python 3 release)
  • Works on Windows 10, macOS, and Linux (e.g. considered file system case-sensitivity)

@d3r3kkd3r3kk requested a review fromDonJayamanneJune 5, 2018 20:51
@d3r3kkd3r3kk self-assigned thisJun 5, 2018
@d3r3kk
Copy link
Author

Spawn a new build...

@d3r3kkd3r3kk reopened thisJun 5, 2018
@codecov
Copy link

codecovbot commentedJun 5, 2018
edited
Loading

Codecov Report

Merging#1872 intomaster willincrease coverage by0.02%.
The diff coverage isn/a.

Impacted file tree graph

@@            Coverage Diff             @@##           master    #1872      +/-   ##==========================================+ Coverage   74.44%   74.46%   +0.02%==========================================  Files         282      282                Lines       13253    13253                Branches     2382     2382              ==========================================+ Hits         9866     9869       +3+ Misses       3257     3253       -4- Partials      130      131       +1
Impacted FilesCoverage Δ
src/client/debugger/Main.ts51.85% <0%> (-0.5%)⬇️
src/client/debugger/mainV2.ts79.91% <0%> (+2%)⬆️

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update7f48a19...6753b27. Read thecomment docs.

@d3r3kkd3r3kk closed thisJun 6, 2018
@d3r3kk
Copy link
Author

Try this out on the new CI definition in VSTS...

@d3r3kkd3r3kk reopened thisJun 6, 2018
@d3r3kkd3r3kk closed thisJun 6, 2018
@d3r3kk
Copy link
Author

Another crack at VSTS CI

@d3r3kkd3r3kk reopened thisJun 6, 2018
@d3r3kkd3r3kk closed thisJun 6, 2018
@d3r3kk
Copy link
Author

Once again...

@d3r3kkd3r3kk reopened thisJun 6, 2018
@d3r3kkd3r3kk closed thisJun 7, 2018
@d3r3kk
Copy link
Author

Once again...

@d3r3kkd3r3kk reopened thisJun 7, 2018
@d3r3kk
Copy link
Author

@DonJayamanne this change actually doesn't seem to have any effect at all. If you look here at the code, and then search the 'testSingleWorkspace' output for that test, you can see theIS_CI_SERVER value is being completely ignored. Perhaps this is due to a shortcoming on the VSTS side, I'll check it out further... but maybe how I've used the environment variable is to blame?

@d3r3kkd3r3kk closed thisJun 7, 2018
@DonJayamanne
Copy link

DonJayamanne commentedJun 7, 2018
edited
Loading

Agreed, something wrong in VSTS, cuz it works as expected on Travis and appveyor

- case insensitive value was failing my use case- VSTS tooling only tests this way too
@d3r3kk
Copy link
Author

I found it. The VSTS env varTF_BUILD is set to"True" in true MSBuild style.

My expression was failing due to case mismatch!

I found that in the VSTS tooling it is enough to test for theexistance of theTF_BUILD environment variable so I've decided to follow that pattern. (I doubt very much a VSTS build agent would ever define that value as "False" or anything else...).

DonJayamanne reacted with thumbs up emoji

@d3r3kkd3r3kk reopened thisJun 7, 2018
@d3r3kk
Copy link
Author

@DonJayamanne yep this fixes it! I'm shoving it in... will watch it and revert tonight if it turns out problematic...

@d3r3kkd3r3kk merged commit4767b3f intomicrosoft:masterJun 7, 2018
@d3r3kkd3r3kk deleted the tf_ci branchJune 7, 2018 19:19
@locklockbot locked asresolvedand limited conversation to collaboratorsJul 31, 2019
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@brettcannonbrettcannonbrettcannon approved these changes

@DonJayamanneDonJayamanneDonJayamanne approved these changes

Assignees

@d3r3kkd3r3kk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@d3r3kk@DonJayamanne@brettcannon

[8]ページ先頭

©2009-2025 Movatter.jp