- Notifications
You must be signed in to change notification settings - Fork630
Add getReviewerUsers method and improve reviewer management#7345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
Copilot wants to merge4 commits intomainChoose a base branch fromcopilot/fix-f29014f2-621f-4deb-a2fc-7588856f482d
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Co-authored-by: alexr00 <38270282+alexr00@users.noreply.github.com>
Co-authored-by: alexr00 <38270282+alexr00@users.noreply.github.com>
Copilot finished work on behalf ofalexr00July 18, 2025 12:44
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
This PR adds a new method
getReviewerUsers
toGitHubRepository
class that specifically handles fetching users with reviewer capability. It follows the same pattern asgetAssignableUsers
but focuses on reviewer permissions, improving the accuracy of reviewer suggestions by specifically querying for users with reviewer permissions rather than using the broader assignable users list.Changes
1. New
getReviewerUsers
method inGitHubRepository
GetSuggestedActors
query with reviewer-specific capabilitiesCAN_BE_REQUESTED_FOR_REVIEW
,CAN_REVIEW
,CAN_BE_ASSIGNED
GetAssignableUsers
if suggested actors API is not available2. Enhanced
FolderRepositoryManager
caching_reviewerUsers
cache property and_fetchReviewerUsersPromise
for async managementgetReviewerUsers(clearCache?)
method with full caching supportgetCachedFromGlobalState
andsaveInGlobalState
to support 'reviewerUsers'3. Updated
getReviewersQuickPickItems
functiongetReviewerUsers()
instead ofgetAssignableUsers()
for more accurate resultsassignableUsers
toreviewerUsers
for clarity4. Unit tests
Benefits
getAssignableUsers
,getMentionableUsers
)Backward Compatibility
The changes are fully backward compatible:
Testing
This change improves the accuracy of reviewer suggestions in the PR creation flow while maintaining full compatibility with existing functionality.
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
update.code.visualstudio.com
node ./out/src/test/runTests.js
(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Created from VS Code via theGitHub Pull Request extension.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn moreCopilot coding agent tips in the docs.