Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Allow authentication for github enterprise#3064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

nicholas-l
Copy link
Contributor

@nicholas-lnicholas-l commentedOct 26, 2021
edited
Loading

This adds a condition for github enterpise session when there is no session for github.com.
I believe thisfixes#3056

@ghost
Copy link

ghost commentedOct 28, 2021
edited by ghost
Loading

CLA assistant check
All CLA requirements met.

Copy link
Member

@alexr00alexr00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I didn't test whether this fixes enterprise, but I did check that it doesn't break github accounts and fixed an issue with that.

@alexr00alexr00 added this to theOctober 2021 milestoneOct 28, 2021
@alexr00
Copy link
Member

@nicholas-l once you sign the license agreement as requested by the bot I will merge this PR.

@alexr00alexr00 self-assigned thisOct 28, 2021
@nicholas-l
Copy link
ContributorAuthor

I have signed the CLA. Also thanks for adding the try-catch, I didn't know it would throw 😃

@alexr00alexr00 merged commit1247940 intomicrosoft:mainOct 28, 2021
@nicholas-lnicholas-l deleted the allow-authentication-for-github-enterprise branchNovember 5, 2021 15:09
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@alexr00alexr00alexr00 approved these changes

Assignees

@alexr00alexr00

Labels
None yet
Projects
None yet
Milestone
October 2021
Development

Successfully merging this pull request may close these issues.

Can't connect to GHE by 0.31.1 when upgrade vscode from 1.61.1 to v1.61.2
2 participants
@nicholas-l@alexr00

[8]ページ先頭

©2009-2025 Movatter.jp