- Notifications
You must be signed in to change notification settings - Fork630
Allow authentication for github enterprise#3064
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Allow authentication for github enterprise#3064
Uh oh!
There was an error while loading.Please reload this page.
Conversation
ghost commentedOct 28, 2021 • edited by ghost
Loading Uh oh!
There was an error while loading.Please reload this page.
edited by ghost
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I didn't test whether this fixes enterprise, but I did check that it doesn't break github accounts and fixed an issue with that.
@nicholas-l once you sign the license agreement as requested by the bot I will merge this PR. |
I have signed the CLA. Also thanks for adding the try-catch, I didn't know it would throw 😃 |
Uh oh!
There was an error while loading.Please reload this page.
This adds a condition for github enterpise session when there is no session for github.com.
I believe thisfixes#3056