Fixes Commit hash should use a monospace font #2957#2968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

alexr00 merged 2 commits intomicrosoft:mainfromburkeholland:burkeholland-issue2957

Oct 26, 2021

Merged

Fixes Commit hash should use a monospace font #2957#2968

alexr00 merged 2 commits intomicrosoft:mainfromburkeholland:burkeholland-issue2957

Oct 26, 2021

Conversation

Copy link

Collaborator

burkeholland commentedAug 27, 2021•
edited by alexr00
Loading

Fixes#2957

Fixes Commit hash should use a monospace font#2957

dfb3de8

alexr00 requested changes

Aug 30, 2021

View reviewed changes

Copy link

Member

alexr00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I see some slightly off positioning/padding/sizing with this:

alexr00 added this to theSeptember 2021 milestone

Sep 1, 2021

alexr00 modified the milestones:September 2021,October 2021

Sep 27, 2021

Add negative margin to account for monospace height differences

1295e3f

Copy link

CollaboratorAuthor

burkeholland commentedOct 8, 2021

SHEESH what a catch!

Ithink this is strictly due to the differences in the having these two fonts next to each other. The easy fix is to just add some negative margin to the.sha class as I don't see it being a problem anywhere else.

alexr00 approved these changes

Oct 26, 2021

View reviewed changes

Copy link

Member