Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix(types): guard theis judgement#814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
dbaeumer merged 1 commit intomicrosoft:mainfromAkatQuas:is-defined
Oct 19, 2021
Merged

fix(types): guard theis judgement#814

dbaeumer merged 1 commit intomicrosoft:mainfromAkatQuas:is-defined
Oct 19, 2021

Conversation

AkatQuas
Copy link
Contributor

Ensure thecandidate is defined before accessing its property.

And unify the statement using namespaceIs.

@AkatQuas
Copy link
ContributorAuthor

Any update on this PR ?

@dbaeumer
Copy link
Member

@AkatQuas the build failed which is very strange. Can you push something again to retrigger it. I can't merge without a green build.

@AkatQuas
Copy link
ContributorAuthor

It turns to a green build afterrebase+force-update push. Thanks for approval.

@dbaeumerdbaeumer merged commit2ad6b71 intomicrosoft:mainOct 19, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@dbaeumerdbaeumerdbaeumer requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@AkatQuas@dbaeumer
[8]ページ先頭
©2009-2025 Movatter.jp