- Notifications
You must be signed in to change notification settings - Fork352
Add support for textDocument/inlineValues#806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
dbaeumer commentedOct 25, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@DanTup I will merge it in, but usually a PR like this needs a markdown file describing the feature so that we can merge it into the protocol later on. And it should all start in proposed state. I will do the necessary changes. |
I saw that you have a PR for this also in LSP land which is fine. Will simply copy the markdown for now. |
This is a first pass at implementing support for inlineValues proposed in the LSP repo atmicrosoft/language-server-protocol#1318 (to mirror VS Code's equivalent APIhttps://code.visualstudio.com/api/references/vscode-api#InlineValuesProvider).
@dbaeumer I haven't built an implementation in a real server yet, but I did add integration/converter tests that are all passing (if I've missed any tests I should've added, please let me know!). I'd like to see this working end to end (eg. a real server having its values rendered inside VS Code) but it may take me a little longer to do that, so I figured it was worth opening a PR for feedback on the code (I don't expect end-to-end testing will result in any significant changes).
I've assumed this would go into 3.17 (as with the spec), but if 3.17 is close to release and that's not feasible, let me know and I'll update them both to 3.18.