Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Support@starting-style#421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
aeschli merged 5 commits intomicrosoft:mainfromlilnasy:starting-style
Mar 13, 2025
Merged

Conversation

@lilnasy
Copy link
Contributor

@lilnasylilnasy commentedJan 1, 2025•
edited
Loading

  • ClosesSupport@starting-style #403
  • I implemented this by following the lead ofsupport @container, prepare 6.2.10 #365 andsupport nested @container #390. If there is more to it, then lmk.
  • I noticed that._parseContainerDeclaration(),._parseMediaDeclaration(),._parseSupportsDeclaration(), and._parseLayerDeclaration() all contain the exact same logic. It seems community contributions over the years kept copying it.
  • To keep the review simple and the diff small, I didn't break the pattern and created a 5th copy in._parseStartingStyleDeclaration(). Might be something to revisit.

breningham, flipeador, hyunbinseo, Jerboas86, and grunghi reacted with thumbs up emojiColonel-Sandvich, Rican7, and Arkellys reacted with hooray emojiColonel-Sandvich and Rican7 reacted with heart emojiColonel-Sandvich and Rican7 reacted with rocket emoji
@lilnasy
Copy link
ContributorAuthor

@aeschli The review comments were addressed.

@aeschli
Copy link
Collaborator

Thanks@lilnasy, looks good!

@aeschliaeschlienabled auto-merge (squash)March 13, 2025 16:14
@vs-code-engineeringvs-code-engineeringbot added this to theMarch 2025 milestoneMar 13, 2025
@aeschliaeschli merged commit1efa811 intomicrosoft:mainMar 13, 2025
3 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@rebornixrebornixrebornix approved these changes

@aeschliaeschliaeschli approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

March 2025

Development

Successfully merging this pull request may close these issues.

Support@starting-style

3 participants

@lilnasy@aeschli@rebornix
[8]ページ先頭
©2009-2025 Movatter.jp