- Notifications
You must be signed in to change notification settings - Fork1.5k
Merging hashes#2181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merging hashes#2181
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Pull request overview
This PR consolidates model hashes by migrating three hash values fromVSC_MODEL_HASHES_B toVSC_MODEL_HASHES_A, effectively merging the model categories.
Key Changes
- Three hash strings (lines 24-26) moved from
VSC_MODEL_HASHES_Barray toVSC_MODEL_HASHES_Aarray VSC_MODEL_HASHES_Bredefined as an array containing only an empty string- Model identification logic remains unchanged
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
| constVSC_MODEL_HASHES_B=[ | ||
| ]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Please leave a comment as to why this is empty.
Also I recommend adding it like this:const VSC_MODEL_HASHES_B : string[] = [];
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
done
682be13 tof935c00Compare149a4fbUh oh!
There was an error while loading.Please reload this page.
Moving model B hashes to Model A.