Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

added svg-sprite generation#84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
miguelsolorio merged 4 commits intomicrosoft:mainfromProfesor08:svg-sprite
Oct 4, 2021

Conversation

Profesor08
Copy link
Contributor

Added generation of svg sprite. It is very useful to target icons by their names without including styles, fonts and class names for elements, and to not worry about font size.

AnWeber reacted with thumbs up emoji
@ghost
Copy link

ghost commentedSep 29, 2021•
edited by ghost
Loading

CLA assistant check
All CLA requirements met.

@miguelsolorio
Copy link

👋 Appreciate the PR, though not sure if we have a need for this and a little concerned about adding another dependency. Do you mind explaining why the current files don't work for you?

@Profesor08
Copy link
ContributorAuthor

👋 Appreciate the PR, though not sure if we have a need for this and a little concerned about adding another dependency. Do you mind explaining why the current files don't work for you?

Almost all icon packs provide different ways to use icons and svg sprite is one of them. Using icons as font put you to work with them as text, it is more difficult to control size and alignment.

@miguelsolorio
Copy link

Had to make some changes to our dependencies (upgradedfantasticon & removednpm-force-resolutions). Do you mind resolving conflicts so I can test this? Thanks.

@Profesor08
Copy link
ContributorAuthor

Had to make some changes to our dependencies (upgradedfantasticon & removednpm-force-resolutions). Do you mind resolving conflicts so I can test this? Thanks.

resolved

@miguelsolorio
Copy link

Tested this out locally and it's looking great!

CleanShot 2021-10-04 at 11 39 11@2x

Is there any way to allow multiple references to the same icon? We have acode pointer file that can map multiple references to the same icon so it would be nice to still support that.

@Profesor08
Copy link
ContributorAuthor

Is there any way to allow multiple references to the same icon?

It is not posible to target one symbol with different ids. Only way is to build sprite manualy with script. I have added a script.

@miguelsolorio
Copy link

This looks perfect, thanks for adding that functionality in!

CleanShot 2021-10-04 at 13 53 00@2x

@miguelsoloriomiguelsolorio merged commit37eabe5 intomicrosoft:mainOct 4, 2021
@miguelsolorio
Copy link

Update the readme with an example for using the svg sprites:

https://github.com/microsoft/vscode-codicons#using-svg-sprites

CleanShot 2021-10-04 at 14 30 13@2x

@miguelsoloriomiguelsolorio self-assigned thisOct 4, 2021
@miguelsoloriomiguelsolorio added this to theOctober 2021 milestoneOct 4, 2021
@Profesor08Profesor08 deleted the svg-sprite branchNovember 5, 2021 08:29
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees

@miguelsoloriomiguelsolorio

Labels
None yet
Projects
None yet
Milestone
October 2021
Development

Successfully merging this pull request may close these issues.

2 participants
@Profesor08@miguelsolorio
[8]ページ先頭
©2009-2025 Movatter.jp