- Notifications
You must be signed in to change notification settings - Fork516
added REQUIRED to the list of cmake operators and added a regex to capture integers#4596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
DARKMOONlite wants to merge1 commit intomicrosoft:release/1.21Choose a base branch fromDARKMOONlite:release/1.21
base:release/1.21
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
…best. Also added in an option that looks for integer values and sets them to be a `constant.numeric.decimal.cmake` token.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
The purpose of this change
To improve readability of CMake code by distinguishing numeric values from other. and adding REQUIRED to the list of parameters that should get some syntactic icing sugar.
I recently was running into issues with a large cmake project and had troubles reading it. After realising that most of my worries came from the fact that I had a deprecated cmake vscode extension that was ruining all syntax highlighting, I decided to try and improve it by submitting what i believe would be a good change to the repo.
Note: I was able to get this working on the main branch as well but since this commitd217cac, effectively removed the advanced syntax highlighting that i was fond of in the latest update I decided to submit the pull request here where they could be combined together to make it very nice to look at. IDK if that was correct, if you want i can submit the pull request from thischange
Other Notes/Information
Example:
This was just a sample
CMakeLists.txtfile, using theAndromeda Italic Borderedtheme with the following pull requestEliverLara/Andromeda#40 which improves its syntax highlighting for cmake.this pull request can be effectively replicated by adding the following code to the
settings.jsonfileAs you can see.
Very Mindful. Very Demure.